Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH 5/5] nfs-utils: add IPv6 code to gssd
Date: Mon, 6 Apr 2009 12:24:09 -0400	[thread overview]
Message-ID: <20090406122409.192523d2@tleilax.poochiereds.net> (raw)
In-Reply-To: <BCFA87B8-22EA-4ABB-87B5-38DAB2621579@oracle.com>

On Mon, 6 Apr 2009 11:35:21 -0400
Chuck Lever <chuck.lever@oracle.com> wrote:

> On Apr 5, 2009, at 9:43 AM, Jeff Layton wrote:
> > All of the pieces to handle IPv6 are now in place. Add IPv6-specific
> > code wrapped in the proper #ifdef's so that IPv6 support works when
> > it's enabled at build-time.
> >
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> > utils/gssd/gssd_proc.c |   34 ++++++++++++++++++++++++++++++++++
> > 1 files changed, 34 insertions(+), 0 deletions(-)
> >
> > diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> > index 1f7dadd..8a595c2 100644
> > --- a/utils/gssd/gssd_proc.c
> > +++ b/utils/gssd/gssd_proc.c
> > @@ -111,10 +111,18 @@ static int
> > addrstr_to_sockaddr(struct sockaddr *sa, const char *addr, const int  
> > port)
> > {
> > 	struct sockaddr_in	*s4 = (struct sockaddr_in *) sa;
> > +#ifdef IPV6_SUPPORTED
> > +	struct sockaddr_in6	*s6 = (struct sockaddr_in6 *) sa;
> > +#endif /* IPV6_SUPPORTED */
> >
> > 	if (inet_pton(AF_INET, addr, &s4->sin_addr)) {
> > 		s4->sin_family = AF_INET;
> > 		s4->sin_port = htons(port);
> > +#ifdef IPV6_SUPPORTED
> > +	} else if (inet_pton(AF_INET6, addr, &s6->sin6_addr)) {
> > +		s6->sin6_family = AF_INET6;
> > +		s6->sin6_port = htons(port);
> > +#endif /* IPV6_SUPPORTED */
> 
> Does this support scope IDs?  Do we expect to get a link-local IPv6  
> address here?
> 

It doesn't support scope ID's. The upcall doesn't send the scopeid if
there's one defined.

Given that we rely on name resolution to some degree with krb5 auth,
I'm not sure that it makes much sense to deal with scopeid's here. AAAA
records in DNS don't have space for them.

PS: I'll fix the getnameinfo() autoconf patch to do what you suggest...

-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2009-04-06 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-05 13:42 [PATCH 0/5] nfs-utils: convert gssd to TI-RPC and add IPv6 support (try #3) Jeff Layton
2009-04-05 13:42 ` [PATCH 1/5] nfs-utils: make getnameinfo() required for --enable-gss Jeff Layton
2009-04-06 15:05   ` Chuck Lever
2009-04-05 13:43 ` [PATCH 2/5] nfs-utils: store the address given in the upcall for later use Jeff Layton
2009-04-06 15:35   ` Chuck Lever
2009-04-06 16:31     ` Jeff Layton
2009-04-06 16:39       ` Chuck Lever
2009-04-05 13:43 ` [PATCH 3/5] nfs-utils: skip getaddrinfo in create_auth_rpc_client unless we need port Jeff Layton
2009-04-05 13:43 ` [PATCH 4/5] nfs-utils: switch gssd to use standard function for getting an RPC client Jeff Layton
2009-04-06 15:35   ` Chuck Lever
2009-04-05 13:43 ` [PATCH 5/5] nfs-utils: add IPv6 code to gssd Jeff Layton
2009-04-06 15:35   ` Chuck Lever
2009-04-06 16:24     ` Jeff Layton [this message]
2009-04-06 16:35       ` Chuck Lever
  -- strict thread matches above, loose matches on Subject: below --
2009-04-07 15:25 [PATCH 0/5] nfs-utils: convert gssd to TI-RPC and add IPv6 support (try #4) Jeff Layton
2009-04-07 15:25 ` [PATCH 5/5] nfs-utils: add IPv6 code to gssd Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090406122409.192523d2@tleilax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox