From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/5] Safer nfsd_cross_mnt()
Date: Wed, 22 Apr 2009 15:20:23 -0400 [thread overview]
Message-ID: <20090422192023.GE9541@fieldses.org> (raw)
In-Reply-To: <20090422191719.GN8633@ZenIV.linux.org.uk>
On Wed, Apr 22, 2009 at 08:17:19PM +0100, Al Viro wrote:
> On Wed, Apr 22, 2009 at 02:06:41PM -0400, J. Bruce Fields wrote:
> > On Tue, Apr 21, 2009 at 09:43:41PM +0000, Al Viro wrote:
> > >
> > > AFAICS, we have a subtle bug there: if we have crossed mountpoint
> > > *and* it got mount --move'd away, we'll be holding only one
> > > reference to fs containing dentry - exp->ex_path.mnt. IOW, we
> > > ought to dput() before exp_put().
> >
> > OK. So a dentry of its own doesn't hold any reference on its
> > filesystem?
>
> Nope. That's why you want vfsmount or superblock reference.
> And export *does* contain vfsmount reference, so everything's fine,
> provided that you drop them in the right order.
Got it, thanks.
--b.
prev parent reply other threads:[~2009-04-22 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 21:43 [PATCH 1/5] Safer nfsd_cross_mnt() Al Viro
2009-04-22 18:06 ` J. Bruce Fields
2009-04-22 19:17 ` Al Viro
2009-04-22 19:20 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422192023.GE9541@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox