Re: Read/Write NFS I/O performance degraded by FLUSH_STABLE page flushing

Trond Myklebust
2009-05-29T18:15:36Z

On Fri, 2009-05-29 at 13:47 -0400, Chuck Lever wrote:
> On May 29, 2009, at 1:42 PM, Trond Myklebust wrote:
>
> > On Fri, 2009-05-29 at 13:38 -0400, Brian R Cowan wrote:
> >>> You may have a misunderstanding about what exactly "async" does.
> >>> The
> >>> "sync" / "async" mount options control only whether the application
> >>> waits for the data to be flushed to permanent storage. They have no
> >>> effect on any file system I know of _how_ specifically the data is
> >>> moved from the page cache to permanent storage.
> >>
> >> The problem is that the client change seems to cause the
> >> application to
> >> stop until this stable write completes... What is interesting is
> >> that it's
> >> not always a write operation that the linker gets stuck on. Our best
> >> hypothesis -- from correlating times in strace and tcpdump traces
> >> -- is
> >> that the FILE_SYNC'ed write NFS RPCs are in fact triggered by
> >> *read()*
> >> system calls on the output file (that is opened for read/write). We
> >> THINK
> >> the read call triggers a FILE_SYNC write if the page is dirty...and
> >> that
> >> is why the read calls are taking so long. Seeing writes happening
> >> when the
> >> app is waiting for a read is odd to say the least... (In my test,
> >> there is
> >> nothing else running on the Virtual machines, so the only thing
> >> that could
> >> be triggering the filesystem activity is the build test...)
> >
> > Yes. If the page is dirty, but not up to date, then it needs to be
> > cleaned before you can overwrite the contents with the results of a
> > fresh read.
> > That means flushing the data to disk... Which again means doing
> > either a
> > stable write or an unstable write+commit. The former is more efficient
> > that the latter, 'cos it accomplishes the exact same work in a single
> > RPC call.
>
> It might be prudent to flush the whole file when such a dirty page is
> discovered to get the benefit of write coalescing.

There are very few workloads where that will help. You basically have to
be modifying the end of a page that has not previously been read in (so
is not already marked up to date) and then writing into the beginning of
the next page, which must also be not up to date.

Trond