From: KOSAKI Motohiro <kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
LKML <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: sk_lock: inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage
Date: Mon, 8 Jun 2009 15:12:05 +0900 (JST) [thread overview]
Message-ID: <20090608150417.437C.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090608055659.GA11538@localhost>
> btw, can anyone explain these NFS warnings? It happens in a very
> memory tight and busy nfsroot system.
>
> [ 113.267340] NFS: Server wrote zero bytes, expected 3671.
> [ 423.202607] NFS: Server wrote zero bytes, expected 108.
> [ 723.588411] NFS: Server wrote zero bytes, expected 560.
> [ 1060.246747] NFS: Server wrote zero bytes, expected 54.
> [ 1397.841183] NFS: Server wrote zero bytes, expected 402.
> [ 1779.545035] NFS: Server wrote zero bytes, expected 319.
server side write function is below
-----------------------------------------------------------
static __be32
nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
loff_t offset, struct kvec *vec, int vlen,
unsigned long *cnt, int *stablep)
{
(snip)
host_err = vfs_writev(file, (struct iovec __user *)vec, vlen, &offset); //(1)
(snip)
/*
* Gathered writes: If another process is currently
* writing to the file, there's a high chance
* this is another nfsd (triggered by a bulk write
* from a client's biod). Rather than syncing the
* file with each write request, we sleep for 10 msec.
*
* I don't know if this roughly approximates
* C. Juszak's idea of gathered writes, but it's a
* nice and simple solution (IMHO), and it seems to
* work:-)
*/
if (EX_WGATHER(exp)) {
(snip)
if (inode->i_state & I_DIRTY) {
dprintk("nfsd: write sync %d\n", task_pid_nr(current));
host_err=nfsd_sync(file); // (2)
}
}
(snip)
dprintk("nfsd: write complete host_err=%d\n", host_err);
if (host_err >= 0) {
err = 0;
*cnt = host_err;
} else
err = nfserrno(host_err);
out:
return err;
}
---------------------------------------------------------------------------
if (1) or (2) makes host_err == 0, it makes your warning messages.
Thanks.
next prev parent reply other threads:[~2009-06-08 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 2:37 sk_lock: inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage Wu Fengguang
2009-06-08 4:55 ` KOSAKI Motohiro
2009-06-08 5:00 ` Wu Fengguang
2009-06-08 5:07 ` KOSAKI Motohiro
[not found] ` <20090608140529.4376.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-06-08 5:53 ` Wu Fengguang
2009-06-08 5:56 ` Wu Fengguang
2009-06-08 6:12 ` KOSAKI Motohiro [this message]
[not found] ` <20090608134428.4373.A69D9226-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-06-09 3:07 ` Wu Fengguang
2009-06-09 3:15 ` KOSAKI Motohiro
2009-07-06 10:52 ` Herbert Xu
2009-07-09 13:17 ` Wu Fengguang
2009-07-10 0:13 ` David Miller
2009-07-10 0:59 ` Herbert Xu
2009-07-10 8:00 ` Wu Fengguang
2009-07-10 8:02 ` Herbert Xu
[not found] ` <20090710080247.GA2693-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2009-07-14 16:04 ` David Miller
2009-07-15 7:45 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608150417.437C.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox