From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: neilb@suse.de, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: handle IPv6 PKTINFO when extracting destination address
Date: Tue, 14 Jul 2009 17:41:42 -0400 [thread overview]
Message-ID: <20090714214141.GI2551@fieldses.org> (raw)
In-Reply-To: <20090713145352.2177.8095.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
On Mon, Jul 13, 2009 at 10:54:26AM -0400, Chuck Lever wrote:
> PKTINFO is needed to scrape the caller's IP address off the socket so
> RPC datagram replies are routed correctly. Fill in missing pieces in
> the kernel RPC server's UDP receive path to request IPv6 PKTINFO and
> correctly parse the IPv6 cmsg header.
>
> Without this patch, kernel RPC services drop all incoming requests on
> UDP on IPv6.
Looks fine, thanks--applied for 2.6.32.
> @@ -531,16 +551,15 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp)
>
> rqstp->rq_prot = IPPROTO_UDP;
>
> - if (cmh->cmsg_level != IPPROTO_IP ||
> - cmh->cmsg_type != IP_PKTINFO) {
> + if (!svc_udp_get_dest_address(rqstp, cmh)) {
(Though personally I would have done this as two patches, with most of
it in a preparatory cleanup patch and the above chunk (which if I
understand right represents the only change in behavior) as the bugfix.)
--b.
next prev parent reply other threads:[~2009-07-14 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 14:54 [PATCH] SUNRPC: handle IPv6 PKTINFO when extracting destination address Chuck Lever
[not found] ` <20090713145352.2177.8095.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2009-07-14 21:41 ` J. Bruce Fields [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-22 17:17 Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714214141.GI2551@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox