public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Haynes <tdh-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: Bug in server's export -- List of security flavors
Date: Thu, 16 Jul 2009 15:45:46 -0400	[thread overview]
Message-ID: <20090716194546.GG2495@fieldses.org> (raw)
In-Reply-To: <4A5F7EA9.9050309-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org>

On Thu, Jul 16, 2009 at 02:25:29PM -0500, Tom Haynes wrote:
> J. Bruce Fields wrote:
>> I don't see how it could be a problem for the client to try an
>> unadvertised flavor.  The server has to enforce the choice of flavor
>> anyway.
>>   
>
> Yes, the server needs to enforce it, but why is the client trying a  
> flavor that the server
> says it does not support?

Could just be excessively persistent of optimistic.  (Or in this case
probably it just doesn't have any negotiation code, so it's simplest
just to try the one flavor that was specified on the mount; seems fair
to me.)

There's also cases where this could also happen just due to bad timing:
maybe the export got changed in the middle.  If only for that reason, I
don't think we could forbid a client from doing this.

>> (Um, but that's pretty weird that the server's advertising an empty
>> list.  What's the nfs-utils version?)
>>
>>   
>
>
> [tdh@adept root]> yum list nfs-utils
> Loaded plugins: dellsysidplugin2, fastestmirror, refresh-packagekit
> updates/metalink                                                          
>                                                              | 2.9 kB     
> 00:00
> updates                                                                   
>                                                              | 4.4 kB     
> 00:00
> Installed Packages
> nfs-utils.i586                                                            
> 1:1.1.5-6.fc11                                                            
>  installed

Thanks!

Hm.  So this change of mine:

	603017f2c1587d760e2649b889b581ca267ffee7 "Determine supported
	pseudoflavors from export"

is probably at fault.  I guess we need to figure out why it's producing
a zero-length array.

--b.

  parent reply	other threads:[~2009-07-16 19:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 16:58 Bug in server's export -- List of security flavors Tom Haynes
     [not found] ` <4A5F5C4C.3070308-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org>
2009-07-16 18:56   ` J. Bruce Fields
2009-07-16 19:25     ` Tom Haynes
     [not found]       ` <4A5F7EA9.9050309-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org>
2009-07-16 19:45         ` J. Bruce Fields [this message]
2009-07-16 20:13           ` Tom Haynes
     [not found]             ` <4A5F8A00.8000104-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org>
2009-07-22  0:09               ` J. Bruce Fields
2009-08-17 17:33                 ` [PATCH] Don't give client an empty flavor list J. Bruce Fields
2009-08-03 13:11         ` Bug in server's export -- List of security flavors Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716194546.GG2495@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=tdh-8AdZ+HgO7noAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox