public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Kirby <sim@hostway.ca>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org, Greg Banks <gnb-xTcybq6BZ68@public.gmane.org>
Subject: Re: kernel NULL pointer dereference in rpcb_getport_done (2.6.29.4)
Date: Tue, 11 Aug 2009 10:17:45 -0700	[thread overview]
Message-ID: <20090811171745.GA31854@hostway.ca> (raw)
In-Reply-To: <20090810235536.GA11617@fieldses.org>

On Mon, Aug 10, 2009 at 07:55:36PM -0400, J. Bruce Fields wrote:

> Looking back at that commit--I'm now confused about how it was meant to
> work.  In the case where the woken-up thread is waiting inside of
> svc_recv(), ->nwaking doesn't get decremented at all until the request
> is processed and svc_recv() is called again--effectively limiting the
> number of concurrent requests to 5 per pool, so, if I read the code
> correctly, likely to cause problems if your workload would benefit from
> lots of requests being able to wait on io simultaneously (e.g. if you
> have a large working set and more than 5 spindles per pool).

Yes, this box is serving about 50 TB of storage space, so there are more
than 5 spindles. :)

I can't believe others aren't all complaining about the same problem, but
I guess the loads are different.

> I'm inclined to revert the patch and take another look at Greg's
> original problem.

I'm inclined to be totally happy with that! :)

Simon-

  reply	other threads:[~2009-08-11 17:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 22:54 kernel NULL pointer dereference in rpcb_getport_done (2.6.29.4) Simon Kirby
2009-06-20 19:57 ` Trond Myklebust
     [not found]   ` <1245527855.5182.33.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-21  5:09     ` Simon Kirby
2009-06-22 21:11       ` Simon Kirby
2009-07-09 17:27         ` Simon Kirby
2009-07-10 22:34           ` J. Bruce Fields
2009-08-10 23:55             ` J. Bruce Fields
2009-08-11 17:17               ` Simon Kirby [this message]
2009-10-15 21:46                 ` Simon Kirby
2009-10-15 22:52                   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090811171745.GA31854@hostway.ca \
    --to=sim@hostway.ca \
    --cc=bfields@fieldses.org \
    --cc=gnb-xTcybq6BZ68@public.gmane.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox