From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 0/6] nfsd: add support for NFSv4 callbacks over IPv6 (try #5) Date: Fri, 21 Aug 2009 11:44:04 -0400 Message-ID: <20090821154404.GD18318@fieldses.org> References: <1250269079-14629-1-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Layton , NFS list , Linux NFSv4 mailing list To: Chuck Lever Return-path: Received: from fieldses.org ([174.143.236.118]:48993 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932435AbZHUPoH (ORCPT ); Fri, 21 Aug 2009 11:44:07 -0400 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Aug 14, 2009 at 02:05:03PM -0400, Chuck Lever wrote: > On Aug 14, 2009, at 12:57 PM, Jeff Layton wrote: >> Fifth attempt at a patchset to add support for NFSv4 callbacks over >> IPv6. Changes from last patchset are mostly to address Chuck's >> comments: >> >> 1) made the new address comparison and copy routines into static >> inlines >> and added them to clnt.h. Ditto for the get_scope_id function. >> >> 2) combined the patch to change nfs4_cb_conn to hold address in >> sockaddr_storage with the one to convert gen_callback to use >> rpc_uaddr2sockaddr. That eliminates changes to the parse_ipv4 function >> that eventually gets ripped out. >> >> Tested using opensolaris and linux and verifying that delegations >> could >> be properly recalled. I also tested mounts to the server's link-local >> address and verified that the callback channel connected correctly. > > Looks good. > > Acked-by: Chuck Lever Applied, thanks to you both. --b.