Re: [pnfs] [PATCH 5/5] nfsd41: replace page based DRC with buffer based DRC

William A. (Andy) Adamson
2009-08-31T13:43:51Z

OK - Thanks for the review. New patches to follow..

-->Andy

On Mon, Aug 31, 2009 at 9:08 AM, J. Bruce Fields<bfields@fieldses.org> =
wrote:
> On Mon, Aug 31, 2009 at 02:10:55AM +0300, Benny Halevy wrote:
>> On Aug. 29, 2009, 0:33 +0300, "J. Bruce Fields" <bfields-uC3wQj2KruMpug/h7KTFAQ@public.gmane.org=
g> wrote:
>> > I think this is OK for now, but maybe stick something like:
>> >
>> > =A0 =A0 BUILD_BUG_ON(NFSD_MAX_SLOTS_PER_SESSION * sizeof(struct nf=
sd4_slot)
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 + sizeof(struct nfsd4_sess=
ion) > PAGE_SIZE);
>> >
>> > in state.h just to warn anyone who wants to blindly bump up
>>
>> I think that the BUILD_BUG_ON should be placed in a function so
>> it gets to compile,
>
> Whoops, thanks--I hadn't noticed that.
>
>> so it'd better be defined here and not in state.h
>> (where it also is in the right context)
>
> Sounds fine.--b.
> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>