public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsmount.conf: New variables that explicitly set default
Date: Fri, 23 Oct 2009 13:20:02 -0400	[thread overview]
Message-ID: <20091023172002.GA31133@fieldses.org> (raw)
In-Reply-To: <4ADF6FA2.50801-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>

On Wed, Oct 21, 2009 at 04:31:30PM -0400, Steve Dickson wrote:
> On 10/21/2009 01:37 PM, Chuck Lever wrote:
> > That should be simple to implement by having nfs_nfs_version
> > leave *version set to zero if the defaultvers= option is rightmost, and
> > then have the new logic you added in nfs_validate_options() additionally
> > strip off defaultvers= before going ahead with the mount attempts.
> > 
> > Does that make sense?
> Yes. but you are assuming defaultvers is a valid mount option and it is
> not. So when/if it does, we can have this discussion then... Plus
> what we have today works just fine and if we want to do tweaks like this 
> later on, so be it... 

It may be hard to change the meaning of "defaultvers" (or whatever) once
it's in use.

--b.

  parent reply	other threads:[~2009-10-23 17:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 18:16 [PATCH] nfsmount.conf: New variables that explicitly set default Steve Dickson
     [not found] ` <4ACF7E0D.6060202-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-09 20:29   ` Chuck Lever
2009-10-09 23:16     ` Steve Dickson
     [not found]       ` <4ACFC458.8060107-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-10  0:38         ` Chuck Lever
2009-10-12  9:24           ` Steve Dickson
     [not found]             ` <4AD2F5B7.9040900-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-12 15:16               ` Chuck Lever
2009-10-12 17:10                 ` Steve Dickson
     [not found]                   ` <4AD36309.1090202-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-15 15:01                     ` Chuck Lever
2009-10-19 12:38                       ` Steve Dickson
     [not found]                         ` <4ADC5DC8.90500-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-21 17:37                           ` Chuck Lever
2009-10-21 20:31                             ` Steve Dickson
     [not found]                               ` <4ADF6FA2.50801-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-10-23 17:20                                 ` J. Bruce Fields [this message]
2009-10-23 17:26                                   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091023172002.GA31133@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=SteveD@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox