From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
NFS list <linux-nfs@vger.kernel.org>,
pNFS Mailing List <pnfs@linux-nfs.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH 1/6] nfsd: Remove nfsfh.h dependency on sunrpc
Date: Wed, 25 Nov 2009 15:57:23 -0500 [thread overview]
Message-ID: <20091125205723.GM32502@fieldses.org> (raw)
In-Reply-To: <4B0B994B.10108@panasas.com>
On Tue, Nov 24, 2009 at 10:28:59AM +0200, Boaz Harrosh wrote:
> On 11/24/2009 12:17 AM, J. Bruce Fields wrote:
> > On Mon, Nov 23, 2009 at 05:58:30PM +0200, Boaz Harrosh wrote:
> >> linux/nfsd/nfsfh.h defines some low level types which
> >> are needed by exportfs and though by filesystems.
> >>
> >> In the file, fh_lock() uses the sunrpc dprint facility which
> >> might cause a dependency of exportfs (and filesystems) on
> >
> > "might cause"?
> >
> > Does mere inclusion of this .h (without referencing fh_lock_nested() or
> > its callers) actually create a dependency?
> >
> > --b.
> >
>
> No, only if code actually uses fh_lock_nested it will cause a dependency.
> Which is only used in fs/nfsd/...
>
> But I would like to discourage nfsd/debug.h at this level.
>
> Should I move fh_lock_nested() and it's siblings to the new private vfs.h header
> you made, and get rid of it this way?
Sure, that sounds reasonable.
--b.
next prev parent reply other threads:[~2009-11-25 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 15:54 [PATCHSET 0-6] nfsd: #includes cleanup Boaz Harrosh
2009-11-23 15:58 ` [PATCH 1/6] nfsd: Remove nfsfh.h dependency on sunrpc Boaz Harrosh
2009-11-23 22:17 ` J. Bruce Fields
2009-11-24 8:28 ` Boaz Harrosh
2009-11-25 20:57 ` J. Bruce Fields [this message]
2009-11-23 15:58 ` [PATCH 2/6] sunrpc: Clean never used include files Boaz Harrosh
2009-11-23 15:59 ` [PATCH 3/6] nfsd: Fix independence of a few nfsd related headers Boaz Harrosh
2009-11-23 15:59 ` [PATCH 4/6] nfsd: Headers Independence and include cleanups Boaz Harrosh
2009-11-23 15:59 ` [PATCH 5/6] nfsd: Source files #include cleanups Boaz Harrosh
2009-11-23 17:26 ` [pnfs] " Boaz Harrosh
2009-11-24 8:17 ` [PATCH 5/6 version2] " Boaz Harrosh
2009-11-24 12:43 ` [pnfs] [PATCH 5/6 version3] " Boaz Harrosh
2009-11-23 16:00 ` [PATCH 6/6] compat.c: Remove dependence on nfsd private headers Boaz Harrosh
2009-11-23 22:14 ` [PATCHSET 0-6] nfsd: #includes cleanup J. Bruce Fields
2009-11-24 12:42 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125205723.GM32502@fieldses.org \
--to=bfields@citi.umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
--cc=randy.dunlap@oracle.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox