From: "J. Bruce Fields" <bfields@fieldses.org>
To: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd4: Use FIRST_NFS4_OP in nfsd4_decode_compound()
Date: Thu, 17 Dec 2009 11:50:53 -0500 [thread overview]
Message-ID: <20091217165053.GB15866@fieldses.org> (raw)
In-Reply-To: <1260590607-9905-1-git-send-email-Ricardo.Labiaga@netapp.com>
On Fri, Dec 11, 2009 at 08:03:27PM -0800, Ricardo Labiaga wrote:
> Since we're checking for LAST_NFS4_OP, use FIRST_NFS4_OP to be consistent.
Got it, thanks.--b.
>
> Signed-off-by: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index b83a24c..3fe0a00 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1442,7 +1442,7 @@ nfsd4_decode_compound(struct nfsd4_compoundargs *argp)
> }
> op->opnum = ntohl(*argp->p++);
>
> - if (op->opnum >= OP_ACCESS && op->opnum <= LAST_NFS4_OP)
> + if (op->opnum >= FIRST_NFS4_OP && op->opnum <= LAST_NFS4_OP)
> op->status = ops->decoders[op->opnum](argp, &op->u);
> else {
> op->opnum = OP_ILLEGAL;
> --
> 1.5.4.3
>
prev parent reply other threads:[~2009-12-17 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 4:03 [PATCH] nfsd4: Use FIRST_NFS4_OP in nfsd4_decode_compound() Ricardo Labiaga
2009-12-17 16:50 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217165053.GB15866@fieldses.org \
--to=bfields@fieldses.org \
--cc=Ricardo.Labiaga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox