From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from userp1040.oracle.com ([156.151.31.81]:21185 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932857Ab3GVS4m convert rfc822-to-8bit (ORCPT ); Mon, 22 Jul 2013 14:56:42 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [PATCH v1 01/19] NFS: Never use user credentials for lease renewal From: Chuck Lever In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA93F4B2750@SACEXCMBX04-PRD.hq.netapp.com> Date: Mon, 22 Jul 2013 14:56:36 -0400 Cc: "linux-nfs@vger.kernel.org" Message-Id: <200ADE3E-431B-4808-AAEC-72FC445A1197@oracle.com> References: <20130712155303.1444.62697.stgit@seurat.1015granger.net> <20130712163135.1444.68565.stgit@seurat.1015granger.net> <1374518026.7972.12.camel@leira.trondhjem.org> <82846EE9-8390-45FF-80DF-E3C04538618B@oracle.com> <4FA345DA4F4AE44899BD2B03EEEC2FA93F4B2750@SACEXCMBX04-PRD.hq.netapp.com> To: "Myklebust, Trond" Sender: linux-nfs-owner@vger.kernel.org List-ID: On Jul 22, 2013, at 2:53 PM, "Myklebust, Trond" wrote: >> -----Original Message----- >> From: Chuck Lever [mailto:chuck.lever@oracle.com] >> Sent: Monday, July 22, 2013 2:52 PM >> To: Myklebust, Trond >> Cc: linux-nfs@vger.kernel.org >> Subject: Re: [PATCH v1 01/19] NFS: Never use user credentials for lease >> renewal >> >> >> On Jul 22, 2013, at 2:33 PM, "Myklebust, Trond" >> wrote: >> >>> On Fri, 2013-07-12 at 12:31 -0400, Chuck Lever wrote: >>>> Don't try to use a non-UID-0 user credential for lease management, as >>>> that credential can change out from under us. The server will block >>>> NFSv4 lease recovery with NFS4ERR_CLID_INUSE. >>>> >>>> Replace minor version-specific callouts with a single function. >>>> >>>> Signed-off-by: Chuck Lever >>>> --- >>>> fs/nfs/nfs4_fs.h | 4 +--- >>>> fs/nfs/nfs4proc.c | 6 +---- >>>> fs/nfs/nfs4session.c | 2 +- >>>> fs/nfs/nfs4state.c | 55 ++++++-------------------------------------------- >>>> 4 files changed, 10 insertions(+), 57 deletions(-) >>> >>> This won't apply to upstream kernels. >> >> Thanks for having a look... As the cover letter stated, this series applies to >> 3.10. >> >> Now that 3.11-rc2 is available, I'm porting the series to the latest upstream, >> with appropriate adjustments for NFSv4.2 support. I hope to post the new >> series tomorrow or Wednesday. >> > OK. Please note that I've already applied 02/19 as that seems to be unrelated to anything else. I'll drop 02/19 from my resend. Thanks. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com