From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 3/3] NFSD: Enable NFS server use of PF_INET6
Date: Wed, 13 Jan 2010 16:10:48 -0500 [thread overview]
Message-ID: <20100113211048.19409.86029.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100113210650.19409.38009.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Try to use an PF_INET6 listener for NFSD if IPv6 is enabled in the
kernel.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfsctl.c | 36 +++++++++++++++++++++++++++++-------
fs/nfsd/nfssvc.c | 27 ++++++++++++++++++++++-----
2 files changed, 51 insertions(+), 12 deletions(-)
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 2604c3e..7ebb7a5 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -981,6 +981,26 @@ static ssize_t __write_ports_delfd(char *buf)
return len;
}
+static ssize_t __write_ports_create_xprt(struct svc_serv *serv,
+ const char *transport,
+ const int family,
+ const unsigned short port)
+{
+ int err;
+
+ err = svc_create_xprt(serv, transport, family, port,
+ SVC_SOCK_ANONYMOUS);
+
+ if (err < 0) {
+ /* Give a reasonable perror msg for bad transport string */
+ if (err == -ENOENT)
+ err = -EPROTONOSUPPORT;
+ return err;
+ }
+
+ return 0;
+}
+
/*
* A transport listener is added by writing it's transport name and
* a port number.
@@ -1000,14 +1020,16 @@ static ssize_t __write_ports_addxprt(char *buf)
if (err != 0)
return err;
- err = svc_create_xprt(nfsd_serv, transport,
- PF_INET, port, SVC_SOCK_ANONYMOUS);
- if (err < 0) {
- /* Give a reasonable perror msg for bad transport string */
- if (err == -ENOENT)
- err = -EPROTONOSUPPORT;
+ err = __write_ports_create_xprt(nfsd_serv, transport, PF_INET, port);
+ if (err < 0)
return err;
- }
+
+#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
+ err = __write_ports_create_xprt(nfsd_serv, transport, PF_INET6, port);
+ if (err < 0 && err != -EAFNOSUPPORT)
+ return err;
+#endif /* CONFIG_IPV6 || CONFIG_IPV6_MODULE */
+
return 0;
}
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 171699e..7af14c1 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -275,14 +275,32 @@ int nfsd_create_serv(void)
return err;
}
-static int nfsd_init_socks(int port)
+static int nfsd_create_xprt(const char *transport, const unsigned short port)
+{
+ int ret;
+
+ ret = svc_create_xprt(nfsd_serv, transport, PF_INET, port,
+ SVC_SOCK_DEFAULTS);
+ if (ret < 0)
+ return ret;
+
+#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
+ ret = svc_create_xprt(nfsd_serv, transport, PF_INET6, port,
+ SVC_SOCK_DEFAULTS);
+ if (ret < 0 && ret != -EAFNOSUPPORT)
+ return ret;
+#endif /* CONFIG_IPV6 || CONFIG_IPV6_MODULE */
+
+ return 0;
+}
+
+static int nfsd_init_socks(const unsigned short port)
{
int error;
if (!list_empty(&nfsd_serv->sv_permsocks))
return 0;
- error = svc_create_xprt(nfsd_serv, "udp", PF_INET, port,
- SVC_SOCK_DEFAULTS);
+ error = nfsd_create_xprt("udp", port);
if (error < 0)
return error;
@@ -290,8 +308,7 @@ static int nfsd_init_socks(int port)
if (error < 0)
return error;
- error = svc_create_xprt(nfsd_serv, "tcp", PF_INET, port,
- SVC_SOCK_DEFAULTS);
+ error = nfsd_create_xprt("tcp", port);
if (error < 0)
return error;
next prev parent reply other threads:[~2010-01-13 21:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 21:10 [PATCH 0/3] NFSD IPv6 patches Chuck Lever
[not found] ` <20100113210650.19409.38009.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-13 21:10 ` [PATCH 1/3] SUNRPC: Use rpc_pton() in ip_map_parse() Chuck Lever
[not found] ` <20100113211031.19409.92550.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-15 22:25 ` J. Bruce Fields
2010-01-15 22:55 ` Chuck Lever
2010-01-15 22:58 ` J. Bruce Fields
2010-01-13 21:10 ` [PATCH 2/3] NFSD: Support AF_INET6 in svc_addsock() function Chuck Lever
2010-01-13 21:10 ` Chuck Lever [this message]
[not found] ` <20100113211048.19409.86029.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-15 22:35 ` [PATCH 3/3] NFSD: Enable NFS server use of PF_INET6 J. Bruce Fields
2010-01-15 23:09 ` Chuck Lever
2010-01-21 22:52 ` J. Bruce Fields
2010-01-22 17:10 ` Chuck Lever
2010-01-22 18:06 ` J. Bruce Fields
2010-01-15 22:44 ` J. Bruce Fields
2010-01-15 23:17 ` Chuck Lever
2010-01-21 22:07 ` J. Bruce Fields
2010-01-22 17:07 ` Chuck Lever
2010-01-22 18:06 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113211048.19409.86029.stgit@localhost.localdomain \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox