public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux NFSv4 mailing list <nfsv4@linux-nfs.org>
Subject: Re: Weird exportfs behavior
Date: Tue, 19 Jan 2010 16:10:15 -0500	[thread overview]
Message-ID: <20100119211015.GA10048@fieldses.org> (raw)
In-Reply-To: <1263934773.2399.162.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>

On Tue, Jan 19, 2010 at 03:59:33PM -0500, David P. Quigley wrote:
> On Tue, 2010-01-19 at 15:48 -0500, J. Bruce Fields wrote:
> > Looks like you have to modify both support/nfs/exports.c:putexportent()
> > and utils/exportfs/exportfs.c:dump(), in addition to parseopts().
> > (Which is really confusing.  Someone should fix that..) Maybe you're
> > forgetting one of those?
> > 
> > --b.
> 
> I'm almost certain I am. I'll look over my patches again to take a look
> at that. I also need to look over my update code for the kernel export
> function because I was getting the labelloc entry in /var/lib/nfs/etab
> on initial daemon start but subsequent exportfs options seem to make it
> go away.

You might have been missing code to parse it or store it in an export,
so it got lost before it wrote the entry back out again?  I don't know.

If you're feeling community-minded, that business with having two
entirely separate bits of code to write out an etab entry seems silly.
(Maybe there are two different formats, I'm forgetting, but if so
couldn't they at least share common code to lookup the string names of
the options?)

--b.

      parent reply	other threads:[~2010-01-19 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 20:32 Weird exportfs behavior David P. Quigley
     [not found] ` <1263933130.2399.160.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>
2010-01-19 20:48   ` J. Bruce Fields
2010-01-19 20:59     ` David P. Quigley
     [not found]       ` <1263934773.2399.162.camel-88+Bj4OksMGWPftkNcioYDMZycKHmlmlfvIqQ387n9k@public.gmane.org>
2010-01-19 21:10         ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100119211015.GA10048@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=dpquigl@tycho.nsa.gov \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox