From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 5/8] NFSv4: Ensure that the NFSv4 locking can recover from stateid errors
Date: Mon, 25 Jan 2010 16:57:35 -0500 [thread overview]
Message-ID: <20100125215735.14716.68912.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100125215734.14716.19614.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
In most cases, we just want to mark the lock_stateid sequence id as being
uninitialised.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
---
fs/nfs/nfs4proc.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 198d51d..0b68238 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -4088,6 +4088,22 @@ static const struct rpc_call_ops nfs4_recover_lock_ops = {
.rpc_release = nfs4_lock_release,
};
+static void nfs4_handle_setlk_error(struct nfs_server *server, struct nfs4_lock_state *lsp, int new_lock_owner, int error)
+{
+ struct nfs_client *clp = server->nfs_client;
+ struct nfs4_state *state = lsp->ls_state;
+
+ switch (error) {
+ case -NFS4ERR_ADMIN_REVOKED:
+ case -NFS4ERR_BAD_STATEID:
+ case -NFS4ERR_EXPIRED:
+ if (new_lock_owner != 0 ||
+ (lsp->ls_flags & NFS_LOCK_INITIALIZED) != 0)
+ nfs4_state_mark_reclaim_nograce(clp, state);
+ lsp->ls_seqid.flags &= ~NFS_SEQID_CONFIRMED;
+ };
+}
+
static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *fl, int recovery_type)
{
struct nfs4_lockdata *data;
@@ -4126,6 +4142,9 @@ static int _nfs4_do_setlk(struct nfs4_state *state, int cmd, struct file_lock *f
ret = nfs4_wait_for_completion_rpc_task(task);
if (ret == 0) {
ret = data->rpc_status;
+ if (ret)
+ nfs4_handle_setlk_error(data->server, data->lsp,
+ data->arg.new_lock_owner, ret);
} else
data->cancelled = 1;
rpc_put_task(task);
next prev parent reply other threads:[~2010-01-25 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 21:57 [PATCH 0/8] What's in the 'bugfixes' branch of the NFS client git tree Trond Myklebust
[not found] ` <20100125215734.14716.19614.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-25 21:57 ` Trond Myklebust [this message]
2010-01-25 21:57 ` [PATCH 1/8] NFS: Fix a reference leak in nfs_wb_cancel_page() Trond Myklebust
2010-01-25 21:57 ` [PATCH 3/8] NFS: Make nfs_commitdata_release static Trond Myklebust
2010-01-25 21:57 ` [PATCH 2/8] NFS: Try to commit unstable writes in nfs_release_page() Trond Myklebust
2010-01-25 21:57 ` [PATCH 6/8] NFSv4: Don't allow posix locking against servers that don't support it Trond Myklebust
2010-01-25 21:57 ` [PATCH 7/8] NFSv4.1: Don't call nfs4_schedule_state_recovery() unnecessarily Trond Myklebust
2010-01-25 21:57 ` [PATCH 4/8] NFS: Avoid warnings when CONFIG_NFS_V4=n Trond Myklebust
2010-01-25 21:57 ` [PATCH 8/8] NFS: Ensure that we handle NFS4ERR_STALE_STATEID correctly Trond Myklebust
2010-01-25 22:39 ` [PATCH 0/8] What's in the 'bugfixes' branch of the NFS client git tree Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125215735.14716.68912.stgit@localhost.localdomain \
--to=trond.myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox