Re: [RFC PATCH 0/4] wsync export option

Christoph Hellwig
2010-02-04T15:21:49Z

On Wed, Feb 03, 2010 at 06:58:31PM -0500, Trond Myklebust wrote:
> Why should the administrator have to both change /etc/fstab
> and /etc/exports? That will be an immediate source of trouble if someone
> changes one without changing the other.

I agree, this should be left to the filesystems.

> Why not rather add an optional operation to the export_ops to let the
> filesystem specify exactly what kind of synchronisation policy is
> optimal for it?

Maybe. But I suspect fsync is actually the right thing to do for
all the filesystems. The only reason why we'd still might want to make
it an export operation is that I'd really prefer not to grow more
instances of fsync without the file pointer. Then again they're
already all in nfs and it doesn't matter too much to audit a few
more places later.