From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] nfsd: default to kernel default for minorversion 1
Date: Fri, 5 Feb 2010 15:05:01 -0500 [thread overview]
Message-ID: <20100205200501.GA28483@fieldses.org> (raw)
In-Reply-To: <20100205192859.GE24926@fieldses.org>
From: J. Bruce Fields <bfields@citi.umich.edu>
The current kernel code should not be enabled by default, because it
does not yet attempt to be a conform completely to the rfc; for example,
some required pieces of protocol are missing.
Therefore the kernel defaults to leaving minorversion1 off. When the
code matures sufficiently, that default will change.
That kernel default becomes meaningless if nfs-utils always explicitly
turns 4.1 on or off. So, nfs-utils should by default do nothing.
Early adopters that want to turn on NFSv4.1 explicitly can still do so
using
echo "+4.1" >/proc/fs/nfsd/versions
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
utils/nfsd/nfssvc.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
index 7bbbaba..1fb420d 100644
--- a/utils/nfsd/nfssvc.c
+++ b/utils/nfsd/nfssvc.c
@@ -239,10 +239,9 @@ nfssvc_setvers(unsigned int ctlbits, int minorvers4)
return;
n = minorvers4 >= 0 ? minorvers4 : -minorvers4;
- if (n >= NFSD_MINMINORVERS4 && n <= NFSD_MAXMINORVERS4)
- off += snprintf(ptr+off, sizeof(buf) - off, "%c4.%d",
- minorvers4 > 0 ? '+' : '-',
- n);
+ if (minorvers4 < 0 && n >= NFSD_MINMINORVERS4
+ && n <= NFSD_MAXMINORVERS4)
+ off += snprintf(ptr+off, sizeof(buf) - off, "-4.%d", n);
for (n = NFSD_MINVERS; n <= NFSD_MAXVERS; n++) {
if (NFSCTL_VERISSET(ctlbits, n))
off += snprintf(ptr+off, sizeof(buf) - off, "+%d ", n);
--
1.6.3.3
next prev parent reply other threads:[~2010-02-05 20:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 22:26 [PATCH 1/2] nfsd: fix version-setting regression on old kernels J. Bruce Fields
2010-01-27 22:26 ` [PATCH 2/2] nfsd: default to kernel default for minorversion 1 J. Bruce Fields
2010-02-01 19:58 ` J. Bruce Fields
2010-02-04 22:19 ` Steve Dickson
[not found] ` <4B6B480C.1050307-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-02-05 16:10 ` J. Bruce Fields
2010-02-05 19:28 ` J. Bruce Fields
2010-02-05 20:05 ` J. Bruce Fields [this message]
2010-02-12 19:58 ` [PATCH] " Steve Dickson
2010-02-12 20:05 ` J. Bruce Fields
2010-02-12 21:44 ` Steve Dickson
2010-02-12 21:55 ` J. Bruce Fields
2010-02-17 19:46 ` Steve Dickson
[not found] ` <4B7C47A2.4010100-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-02-18 12:07 ` Steve Dickson
2010-02-19 2:07 ` J. Bruce Fields
2010-02-04 21:37 ` [PATCH 1/2] nfsd: fix version-setting regression on old kernels Steve Dickson
[not found] ` <4B6B3E30.8090907-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-02-04 21:47 ` J. Bruce Fields
2010-02-04 22:06 ` Steve Dickson
[not found] ` <4B6B44EA.7060602-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-02-04 22:16 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205200501.GA28483@fieldses.org \
--to=bfields@citi.umich.edu \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox