From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] lockd: release reference to nsm_handle in nlm_host_rebooted
Date: Mon, 8 Feb 2010 16:19:08 -0500 [thread overview]
Message-ID: <20100208211908.GB14942@fieldses.org> (raw)
In-Reply-To: <1265400552-8375-1-git-send-email-jlayton@redhat.com>
On Fri, Feb 05, 2010 at 03:09:12PM -0500, Jeff Layton wrote:
> nsm_reboot_lookup takes a reference to the nsm_handle that it returns,
> but nlm_host_rebooted never releases that reference.
Makes sense to me; I'll apply to the nfsd tree.
(How did you run across this?)
--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/lockd/host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index 4600c20..bb464d1 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -479,8 +479,8 @@ again: mutex_lock(&nlm_host_mutex);
> }
> }
> }
> -
> mutex_unlock(&nlm_host_mutex);
> + nsm_release(nsm);
> }
>
> /*
> --
> 1.6.6
>
next prev parent reply other threads:[~2010-02-08 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 20:09 [PATCH] lockd: release reference to nsm_handle in nlm_host_rebooted Jeff Layton
2010-02-08 21:19 ` J. Bruce Fields [this message]
2010-02-08 21:34 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208211908.GB14942@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox