From: Arjan van de Ven <arjan@infradead.org>
To: chihau Chau <chihau@gmail.com>
Cc: bfields@fieldses.org, neilb@suse.de, viro@zeniv.linux.org.uk,
Trond.Myklebust@netapp.com, bharrosh@panasas.com,
akpm@linux-foundation.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Chihau Chau <chihau@gmail.com>
Subject: Re: [PATCH] fs: nfsd: export: fix coding style issues
Date: Mon, 8 Feb 2010 21:36:43 -0800 [thread overview]
Message-ID: <20100208213643.540d92a4@infradead.org> (raw)
In-Reply-To: <1265665013-32162-1-git-send-email-chihau@gmail.com>
> -static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old);
> +static struct svc_expkey *svc_expkey_update(struct svc_expkey *new,
> + struct svc_expkey *old);
how is this an improvement ? I don't find the 2nd more more readable
also, are you planning to do real changes to this file? If not, I would suggest not doing cleanups like this;
while cleanups like the other things you did are fine as a first step to doing real work on a file, it's usually
not liked very much to ONLY do such cosmetic things...
prev parent reply other threads:[~2010-02-09 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 21:36 [PATCH] fs: nfsd: export: fix coding style issues chihau Chau
2010-02-09 5:36 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208213643.540d92a4@infradead.org \
--to=arjan@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bharrosh@panasas.com \
--cc=chihau@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox