Re: [RFC PATCH 1/2] commit_metadata export operation and nfsd_sync2

Christoph Hellwig
2010-02-10T21:57:00Z

On Wed, Feb 10, 2010 at 01:53:43PM -0600, bpm@sgi.com wrote:
> > I think Trond explained that we do not want force data to disk here.
>
> Thought so. I was making an effort to punch all the same buttons as
> before so that behavior wouldn't change for filesystems other than xfs
> until they're ready.

Well, the data writing really isn't filesystem dependent, but depends
on the nfs semantics.

> > Btw, as we don't need to write data to disk this should be a
> > sync_inode calls with the following second argument:
> >
> > struct writeback_control wbc = {
> > .sync_mode = WB_SYNC_ALL,
> > .nr_to_write = 0, /* metadata-only */
> > };
>
> So, uh, are you suggesting that I use file_operations.fsync,
> write_inode_now, vfs_fsync, write_inode, sync_inode, or
> super_operations.write_inode? Would it be good to stay away from the
> inode_lock?

->write_inode is the method that both write_inode_now and sync_inode
end up calling, in fact write_inode_now could be implemented on top
of sync_inode. The difference is that write_inode_now already
prepares a writeback_control structure that already writes out data,
and optionally waits for data I/O to complete, while sync_inode
leaves all that to the caller. If we dont want to bother with
writing out data we have to use sync_inode if we want to use
the ->write_inode path. Given that we want to make changes that
happened through the filesystem metadata methods stable and not
user data using ->write_inode makes more sense to me than ->fsync.
Especially as ->fsync normally requires a file pointer and only
allows that to be NULL for nfs, which requires special cases all
over the place that we could get rid of.

The global lock in that path is not nice, but Nick Piggin has already
started splitting it up.