Re: [PATCH] sunrpc: remove unnecessary svc_xprt_put

J. Bruce Fields
2010-03-01T14:43:33Z

On Mon, Mar 01, 2010 at 03:23:10PM +1100, Neil Brown wrote:
> On Fri, 26 Feb 2010 20:38:25 -0600
> Tom Tucker <tom@opengridcomputing.com> wrote:
>
> > Neil Brown wrote:
> > > On Fri, 26 Feb 2010 18:40:58 -0600
> > > Tom Tucker <tom@opengridcomputing.com> wrote:
> > >
> > >
> > >> J. Bruce Fields wrote:
> > >>
> > >>> On Sat, Feb 27, 2010 at 09:33:40AM +1100, Neil Brown wrote:
> > >>>
> > >>>
> > >>>> [I found this while looking for the current refcount problem
> > >>>> that triggers a warning in svc_recv. This isn't that bug
> > >>>> but is a different refcount bug - NB]
> > >>>>
> > >>>>
> > >>>
> > >>>
> > >> I seem to recall that we added that reference for a reason. There was
> > >> an issue with unmount while there were deferrals pending. That's why the
> > >> reference was added.
> > >>
> > >> Tom
> > >>
> > >
> > > What reference?
> > > What I (thought I) found was code that was dropping a reference which it
> > > didn't hold. Are you saying that it is supposed to be holding a reference
> > > here, but isn't, or that it really is holding a reference here and I didn't
> > > see it?
> > >
> >
> > Here's the commit that I was thinking of...
> > 22945e4a1c7454c97f5d8aee1ef526c83fef3223
> >
> > I think this change adds the bug that you are now fixing. It fixed one
> > problem, but added another that you have now resolved.
> >
> > What do you guys think?
>
> Yes, I see what you are saying.
>
> I agree that commit did fix a problem, but inadvertently introduced a new one.

Agreed. So it looks to there's nothing additional here to fix.
(Correct me if I'm overlooking something.)

--b.