Re: [PATCH] nfsd: no need to open the file on a COMMIT call

Christoph Hellwig
2010-03-18T21:13:07Z

On Thu, Mar 18, 2010 at 03:34:47PM -0400, Jeff Layton wrote:
> There's no need to call nfsd_open when a COMMIT call comes in over the
> wire. It doesn't really buy us anything to pass a filp into
> vfs_fsync_range.

Yes, it does. Having the braindead calling convention with a possible
NULL file pointer is a real pain for all lower levels, and I have
patches ready to remove the last occurance of that, so please do not
introduce a new one.