Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: steved@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/4] libexport.a: Add client_free()
Date: Mon, 19 Apr 2010 16:21:12 -0400	[thread overview]
Message-ID: <20100419202111.3567.97747.stgit@matisse.1015granger.net> (raw)
In-Reply-To: <20100419201855.3567.9644.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>

Clean up: Introduce a helper to free a nfs_client record.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 support/export/client.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/support/export/client.c b/support/export/client.c
index 6a25928..859dcf1 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -52,6 +52,13 @@ init_addrlist(nfs_client *clp, const struct hostent *hp)
 	clp->m_naddr = i;
 }
 
+static void
+client_free(nfs_client *clp)
+{
+	xfree(clp->m_hostname);
+	xfree(clp);
+}
+
 /* if canonical is set, then we *know* this is already a canonical name
  * so hostname lookup is avoided.
  * This is used when reading /proc/fs/nfs/exports
@@ -209,8 +216,7 @@ client_freeall(void)
 		head = clientlist + i;
 		while (*head) {
 			*head = (clp = *head)->m_next;
-			xfree(clp->m_hostname);
-			xfree(clp);
+			client_free(clp);
 		}
 	}
 }


  parent reply	other threads:[~2010-04-19 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 20:20 [PATCH 0/4] Four more pre-requisites for mountd IPv6 support Chuck Lever
     [not found] ` <20100419201855.3567.9644.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2010-04-19 20:21   ` Chuck Lever [this message]
2010-04-19 20:21   ` [PATCH 2/4] libexport.a: Allow client_init() to fail instead of exit Chuck Lever
2010-04-19 20:21   ` [PATCH 3/4] libexport.a: Allow m_hostname allocation " Chuck Lever
2010-04-19 20:21   ` [PATCH 4/4] libexport.a: Allow malloc(3) failures in client_lookup() and friends Chuck Lever
2010-04-20 12:16   ` [PATCH 0/4] Four more pre-requisites for mountd IPv6 support Jeff Layton
2010-04-23 16:29 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419202111.3567.97747.stgit@matisse.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox