From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd4: fix filehandle comment
Date: Wed, 28 Apr 2010 17:46:14 -0400 [thread overview]
Message-ID: <20100428214614.GD23474@fieldses.org> (raw)
In-Reply-To: <4BD8A9E8.8060608@oracle.com>
On Wed, Apr 28, 2010 at 05:34:32PM -0400, Chuck Lever wrote:
> On 04/28/2010 05:31 PM, J. Bruce Fields wrote:
>> From: J. Bruce Fields<bfields@citi.umich.edu>
>>
>> Minor typos.
>>
>> Signed-off-by: J. Bruce Fields<bfields@citi.umich.edu>
>> ---
>> include/linux/nfsd/nfsfh.h | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/nfsd/nfsfh.h b/include/linux/nfsd/nfsfh.h
>> index 65e333a..45bb5a8 100644
>> --- a/include/linux/nfsd/nfsfh.h
>> +++ b/include/linux/nfsd/nfsfh.h
>> @@ -40,8 +40,8 @@ struct nfs_fhbase_old {
>> * This is the new flexible, extensible style NFSv2/v3 file handle.
>> * by Neil Brown<neilb-YbfuJp6tym7X/JP9YwkgDA@public.gmane.org> - March 2000
>> *
>> - * The file handle is seens as a list of 4byte words.
>> - * The first word contains a version number (1) and four descriptor bytes
>> + * The file handle is seens as a list of four-byte words.
>
> seens? seen? sent?
Tunnel-vision, I guess. Better?:
commit 97fe4c3909cee35fa4732694c3837c35f02d7b32
Author: J. Bruce Fields <bfields@citi.umich.edu>
Date: Wed Apr 28 17:45:06 2010 -0400
nfsd: further comment typos
Whoops, missed some more.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
diff --git a/include/linux/nfsd/nfsfh.h b/include/linux/nfsd/nfsfh.h
index 45bb5a8..80d55bb 100644
--- a/include/linux/nfsd/nfsfh.h
+++ b/include/linux/nfsd/nfsfh.h
@@ -40,12 +40,12 @@ struct nfs_fhbase_old {
* This is the new flexible, extensible style NFSv2/v3 file handle.
* by Neil Brown <neilb-YbfuJp6tym7X/JP9YwkgDA@public.gmane.org> - March 2000
*
- * The file handle is seens as a list of four-byte words.
+ * The file handle starts with a sequence of four-byte words.
* The first word contains a version number (1) and three descriptor bytes
* that tell how the remaining 3 variable length fields should be handled.
* These three bytes are auth_type, fsid_type and fileid_type.
*
- * All 4byte values are in host-byte-order.
+ * All four-byte values are in host-byte-order.
*
* The auth_type field specifies how the filehandle can be authenticated
* This might allow a file to be confirmed to be in a writable part of a
next prev parent reply other threads:[~2010-04-28 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 21:31 [PATCH] nfsd4: fix filehandle comment J. Bruce Fields
2010-04-28 21:34 ` Chuck Lever
2010-04-28 21:46 ` J. Bruce Fields [this message]
2010-04-28 21:52 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428214614.GD23474@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).