From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 20/24] NFS: Decode NFSv2 read reply using an xdr_stream
Date: Sun, 16 May 2010 22:48:34 -0400 [thread overview]
Message-ID: <20100517024834.20258.49846.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100517023905.20258.86631.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfs/nfs2xdr.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/nfs2xdr.c b/fs/nfs/nfs2xdr.c
index 164c06d..807c1b1 100644
--- a/fs/nfs/nfs2xdr.c
+++ b/fs/nfs/nfs2xdr.c
@@ -1032,6 +1032,55 @@ static int nfs2_xdr_dec_readlinkres(struct rpc_rqst *req, __be32 *p,
}
/*
+ * 2.2.7. readres
+ *
+ * union readres switch (stat status) {
+ * case NFS_OK:
+ * fattr attributes;
+ * nfsdata data;
+ * default:
+ * void;
+ * };
+ */
+static int nfs2_xdr_dec_readres(struct rpc_rqst *req, __be32 *p,
+ struct nfs_readres *result)
+{
+ struct xdr_stream xdr;
+ enum nfs_stat status;
+ u32 recvd, count;
+ size_t hdrlen;
+
+ xdr_init_decode(&xdr, &req->rq_rcv_buf, p);
+ if (decode_stat(&xdr, &status) != 0)
+ return -EIO;
+ if (status != NFS_OK)
+ return nfs_stat_to_errno(status);
+ if (decode_fattr(&xdr, result->fattr) != 0)
+ return -EIO;
+
+ /* nfsdata */
+ p = xdr_inline_decode(&xdr, 4);
+ if (unlikely(p == NULL)) {
+ print_overflow_msg(__func__, &xdr);
+ return -EIO;
+ }
+ count = be32_to_cpup(p);
+ hdrlen = (u8 *)xdr.p - (u8 *)xdr.iov->iov_base;
+ recvd = xdr.buf->len - hdrlen;
+ if (count > recvd) {
+ dprintk("NFS: server cheating in read result: "
+ "count %u > recvd %u\n", count, recvd);
+ count = recvd;
+ }
+ xdr_read_pages(&xdr, count);
+
+ /* NFSv2 doesn't pass EOF flag on the wire. */
+ result->eof = 0;
+ result->count = count;
+ return count;
+}
+
+/*
* Decode WRITE reply
*/
static int
next prev parent reply other threads:[~2010-05-17 2:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 2:45 [PATCH 00/24] Modernize NFSv2 XDR encoder/decoders Chuck Lever
[not found] ` <20100517023905.20258.86631.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-05-17 2:45 ` [PATCH 01/24] SUNRPC: Refactor logic to NUL-terminate strings in pages Chuck Lever
2010-05-17 2:45 ` [PATCH 02/24] NFS: Introduce XDR helpers for basic NFSv2 data types Chuck Lever
2010-05-17 2:46 ` [PATCH 03/24] NFS: Encode NFSv2 fhandle argument using an xdr_stream Chuck Lever
2010-05-17 2:46 ` [PATCH 04/24] NFS: Encode v2 setattr " Chuck Lever
2010-05-17 2:46 ` [PATCH 05/24] NFS: Encode dirop " Chuck Lever
2010-05-17 2:46 ` [PATCH 06/24] NFS: Encode NFSv2 readlink " Chuck Lever
2010-05-17 2:46 ` [PATCH 07/24] NFS: Encode NFSv2 read " Chuck Lever
2010-05-17 2:46 ` [PATCH 08/24] NFS: Encode NFSv2 write " Chuck Lever
2010-05-17 2:46 ` [PATCH 09/24] NFS: Encode NFSv2 create " Chuck Lever
2010-05-17 2:47 ` [PATCH 10/24] NFS: Encode NFSv2 rename " Chuck Lever
2010-05-17 2:47 ` [PATCH 11/24] NFS: Encode NFSv2 link " Chuck Lever
2010-05-17 2:47 ` [PATCH 12/24] NFS: Encode NFSv2 symlink " Chuck Lever
2010-05-17 2:47 ` [PATCH 13/24] NFS: Encode NFSv2 readdir " Chuck Lever
2010-05-17 2:47 ` [PATCH 14/24] NFS: Replace old NFSv2 encoder functions with xdr_stream-based ones Chuck Lever
2010-05-17 2:47 ` [PATCH 15/24] NFS: Use the "nfs_stat" enum for nfs_stat_to_errno() Chuck Lever
2010-05-17 2:47 ` [PATCH 16/24] NFS: Decode NFSv2 stat reply using an xdr_stream Chuck Lever
2010-05-17 2:48 ` [PATCH 17/24] NFS: Decode NFSv2 attrstat " Chuck Lever
2010-05-17 2:48 ` [PATCH 18/24] NFS: Decode NFSv2 dirop " Chuck Lever
2010-05-17 2:48 ` [PATCH 19/24] NFS: Decode NFSv2 readlink " Chuck Lever
2010-05-17 2:48 ` Chuck Lever [this message]
2010-05-17 2:48 ` [PATCH 21/24] NFS: Decode NFSv2 write " Chuck Lever
2010-05-17 2:48 ` [PATCH 22/24] NFS: Decode NFSv2 readdir " Chuck Lever
2010-05-17 2:49 ` [PATCH 23/24] NFS: Decode NFSv2 statfs " Chuck Lever
2010-05-17 2:49 ` [PATCH 24/24] NFS: Replace old NFSv2 decoder functions with xdr_stream-based ones Chuck Lever
2010-05-17 20:57 ` [PATCH 00/24] Modernize NFSv2 XDR encoder/decoders Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517024834.20258.49846.stgit@localhost.localdomain \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).