Deadlock/crash in 2.6.32.12 when copying large files

Deadlock/crash in 2.6.32.12 when copying large files

[Leszek Urbanski]

Hi,

I've hit https://bugzilla.kernel.org/show_bug.cgi?id=15578 again with
2.6.32.12 on amd64.

I can reproduce it every time when copying large (>2G) files over NFS.
The call trace is at https://bugzilla.kernel.org/attachment.cgi?id=26519

Needless to say it results in a system crash (kswapd deadlock, network stack
failure because of memory allocation failure for SKBs, etc.).

Trond Myklebust closed this bug a while ago, but apparently it's not completely
fixed and needs to be re-opened.


-- 
Leszek Urbanski

Re: Deadlock/crash in 2.6.32.12 when copying large files

[Lukas Hejtmanek]

Hi,

On Wed, May 26, 2010 at 12:26:57AM +0200, Leszek Urbanski wrote:
> I've hit https://bugzilla.kernel.org/show_bug.cgi?id=15578 again with
> 2.6.32.12 on amd64.
> 
> I can reproduce it every time when copying large (>2G) files over NFS.
> The call trace is at https://bugzilla.kernel.org/attachment.cgi?id=26519
> 
> Needless to say it results in a system crash (kswapd deadlock, network stack
> failure because of memory allocation failure for SKBs, etc.).
> 
> Trond Myklebust closed this bug a while ago, but apparently it's not completely
> fixed and needs to be re-opened.

You could try this workaround, it works for me. Cherry picked from 2.6.34
vanila.

commit 3d7b08945e54a3a5358d5890240619a013cb7388
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Apr 22 15:35:55 2010 -0400

    SUNRPC: Fix a bug in rpcauth_prune_expired

    Don't want to evict a credential if cred->cr_expire == jiffies, since that
    means that it was just placed on the cred_unused list. We therefore need to
    use time_in_range() rather than time_in_range_open().

    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index f394fc1..95afe79 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -237,7 +237,7 @@ rpcauth_prune_expired(struct list_head *free, int
nr_to_scan)
        list_for_each_entry_safe(cred, next, &cred_unused, cr_lru) {

                /* Enforce a 60 second garbage collection moratorium */
-               if (time_in_range_open(cred->cr_expire, expired, jiffies) &&
+               if (time_in_range(cred->cr_expire, expired, jiffies) &&
                    test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0)
                        continue;


-- 
Lukáš Hejtmánek