From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@lst.de>
Cc: bpm@sgi.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: nfsd_setattr needs to call commit_metadata
Date: Tue, 1 Jun 2010 19:18:49 -0400 [thread overview]
Message-ID: <20100601231849.GE27423@fieldses.org> (raw)
In-Reply-To: <20100601195917.GA25910@lst.de>
On Tue, Jun 01, 2010 at 09:59:18PM +0200, Christoph Hellwig wrote:
> The conversion of write_inode_now calls to commit_metadata in commit
> f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.
>
> But without this conversion we can't guarantee that a SETATTR request
> has actually been commited to disk with XFS, which causes a regression
> from 2.6.32 (only for NFSv2, but anyway).
Got it, thanks.
--b.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/nfsd/vfs.c
> ===================================================================
> --- linux-2.6.orig/fs/nfsd/vfs.c 2010-06-01 21:24:34.945004695 +0200
> +++ linux-2.6/fs/nfsd/vfs.c 2010-06-01 21:25:48.299003856 +0200
> @@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
> if (size_change)
> put_write_access(inode);
> if (!err)
> - if (EX_ISSYNC(fhp->fh_export))
> - write_inode_now(inode, 1);
> + commit_metadata(fhp);
> out:
> return err;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-06-01 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 19:59 [PATCH] nfsd: nfsd_setattr needs to call commit_metadata Christoph Hellwig
2010-06-01 23:18 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601231849.GE27423@fieldses.org \
--to=bfields@fieldses.org \
--cc=bpm@sgi.com \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).