* [PATCH] nfsd: nfsd_setattr needs to call commit_metadata
@ 2010-06-01 19:59 Christoph Hellwig
2010-06-01 23:18 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-06-01 19:59 UTC (permalink / raw)
To: bfields; +Cc: bpm, linux-nfs
The conversion of write_inode_now calls to commit_metadata in commit
f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.
But without this conversion we can't guarantee that a SETATTR request
has actually been commited to disk with XFS, which causes a regression
from 2.6.32 (only for NFSv2, but anyway).
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/nfsd/vfs.c
===================================================================
--- linux-2.6.orig/fs/nfsd/vfs.c 2010-06-01 21:24:34.945004695 +0200
+++ linux-2.6/fs/nfsd/vfs.c 2010-06-01 21:25:48.299003856 +0200
@@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
if (size_change)
put_write_access(inode);
if (!err)
- if (EX_ISSYNC(fhp->fh_export))
- write_inode_now(inode, 1);
+ commit_metadata(fhp);
out:
return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: nfsd_setattr needs to call commit_metadata
2010-06-01 19:59 [PATCH] nfsd: nfsd_setattr needs to call commit_metadata Christoph Hellwig
@ 2010-06-01 23:18 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2010-06-01 23:18 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: bpm, linux-nfs
On Tue, Jun 01, 2010 at 09:59:18PM +0200, Christoph Hellwig wrote:
> The conversion of write_inode_now calls to commit_metadata in commit
> f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.
>
> But without this conversion we can't guarantee that a SETATTR request
> has actually been commited to disk with XFS, which causes a regression
> from 2.6.32 (only for NFSv2, but anyway).
Got it, thanks.
--b.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/nfsd/vfs.c
> ===================================================================
> --- linux-2.6.orig/fs/nfsd/vfs.c 2010-06-01 21:24:34.945004695 +0200
> +++ linux-2.6/fs/nfsd/vfs.c 2010-06-01 21:25:48.299003856 +0200
> @@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
> if (size_change)
> put_write_access(inode);
> if (!err)
> - if (EX_ISSYNC(fhp->fh_export))
> - write_inode_now(inode, 1);
> + commit_metadata(fhp);
> out:
> return err;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-01 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-01 19:59 [PATCH] nfsd: nfsd_setattr needs to call commit_metadata Christoph Hellwig
2010-06-01 23:18 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).