From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 1/3] nfsd: don't try to shut down nfs4 state handling unless it's up Date: Tue, 8 Jun 2010 19:58:28 -0400 Message-ID: <20100608235828.GK26435@fieldses.org> References: <1275924800-5214-1-git-send-email-jlayton@redhat.com> <1275924800-5214-2-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org To: Jeff Layton Return-path: Received: from fieldses.org ([174.143.236.118]:44817 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754732Ab0FHX63 (ORCPT ); Tue, 8 Jun 2010 19:58:29 -0400 In-Reply-To: <1275924800-5214-2-git-send-email-jlayton@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Jun 07, 2010 at 11:33:18AM -0400, Jeff Layton wrote: > If someone tries to shut down the laundry_wq while it isn't up it'll > cause an oops. OK, thanks. Hm: what about the opposite (admittedly probably less crucial) problem: are there cases where nfs4_state_start() gets called but never nfs4_state_shutdown? >>From a quick look, I don't see what prevents that. --b. > > Signed-off-by: Jeff Layton > --- > fs/nfsd/nfs4state.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 1176708..fc52920 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -4124,6 +4124,8 @@ __nfs4_state_shutdown(void) > void > nfs4_state_shutdown(void) > { > + if (!nfs4_init) > + return; > cancel_rearming_delayed_workqueue(laundry_wq, &laundromat_work); > destroy_workqueue(laundry_wq); > locks_end_grace(&nfsd4_manager); > -- > 1.5.5.6 >