Re: [PATCH 1/3] nfsd: don't try to shut down nfs4 state handling unless it's up

J. Bruce Fields
2010-06-15T17:36:29Z

On Tue, Jun 15, 2010 at 01:36:22PM -0400, Jeff Layton wrote:
> On Sun, 13 Jun 2010 16:28:42 -0400
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> > On Wed, Jun 09, 2010 at 02:29:43PM -0400, Jeff Layton wrote:
> > > Ahh ok, I see what you're talking about now. Yeah, that should probably
> > > also be fixed. I think we just need to ensure to shut down the state in
> > > an error condition. Something like this compile-tested only patch?
> > >
> > > From 19bd25ea9a76ea184e4c30831765e812ce19b0a5 Mon Sep 17 00:00:00 2001
> > > From: Jeff Layton <jlayton@redhat.com>
> > > Date: Wed, 9 Jun 2010 14:21:51 -0400
> > > Subject: [PATCH] nfsd: shut down NFSv4 state when nfsd_svc encounters an error
> > >
> > > Currently, it's left up in some situations. That could cause the grace
> > > period to be shorter than it should be (along with other problems).
> >
> > The patch looks right to me, thanks.
> >
> > --b.
> >
>
> FWIW, I've done a bit of testing with this patch on top of the other
> set and it seems to be ok. That said, I don't have a reliable test that
> makes the state setup "leak" like this, so I can't really say much
> other than that it seems to be ok.

OK, thanks. It should show up in my 2.6.36 tree sometime soon.

--b.