From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] NFS: Fix up the fsync code
Date: Mon, 12 Jul 2010 21:13:06 -0400 [thread overview]
Message-ID: <20100713011306.GA364@infradead.org> (raw)
In-Reply-To: <20100712220932.20019.21170.stgit@heimdal.trondhjem.org>
> /* Flush writes to the server and return any errors */
> - return nfs_do_fsync(ctx, inode);
> + return vfs_fsync(file, 0);
Either the argument to vfs_fsync or the comment needs some changes.
datasync = 0 means we don't just flush writes but also metadata. I
don't know enough about the NFS CTO guarantees to figure which one you
actually want.
next prev parent reply other threads:[~2010-07-13 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 22:09 [PATCH 1/3] NFS: Fix up the fsync code Trond Myklebust
2010-07-12 22:09 ` [PATCH 2/3] NFS: Clean up the callers of nfs_wb_all() Trond Myklebust
2010-07-12 22:09 ` [PATCH 3/3] NFS: nfs_rename() should not have to flush out writebacks Trond Myklebust
2010-07-13 1:13 ` Christoph Hellwig [this message]
2010-07-13 19:50 ` [PATCH 1/3] NFS: Fix up the fsync code Trond Myklebust
2010-07-14 7:00 ` Christoph Hellwig
2010-07-14 13:17 ` Trond Myklebust
2010-08-13 8:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713011306.GA364@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).