From: Jeff Layton <jlayton@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/5] nfsd: don't try to shut down nfs4 state handling unless it's up
Date: Mon, 19 Jul 2010 20:54:50 -0400 [thread overview]
Message-ID: <20100719205450.3a194116@corrin.poochiereds.net> (raw)
In-Reply-To: <20100719220837.GA31074@fieldses.org>
On Mon, 19 Jul 2010 18:08:37 -0400
"J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Mon, Jul 19, 2010 at 04:50:04PM -0400, Jeff Layton wrote:
> > If someone tries to shut down the laundry_wq while it isn't up it'll
> > cause an oops.
>
> nfs4_state_shutdown is called only from nfsd_last_thread, which is
> called only after svc_create_pooled, which is called only when
> nfs4_state_start() succeeds.
>
> If you've actually seen this happen then there's something going on that
> I don't understand.
>
> --b.
I've not seen this in current code, but this delta is a prerequisite
for the next patch in the series. It's possible for nfsd_serv to be
created (via the write_ports interface), but for the threads file never
to be written.
With the next patch in the series, the nfsd_serv can be torn down in an
error condition before the threads file is ever written and at that
point this patch is required to prevent panics.
Cheers,
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2010-07-20 0:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 20:50 [PATCH 0/5] nfsd: fix error handling in write_ports interfaces (resend) Jeff Layton
2010-07-19 20:50 ` [PATCH 1/5] nfsd: don't try to shut down nfs4 state handling unless it's up Jeff Layton
2010-07-19 22:08 ` J. Bruce Fields
2010-07-20 0:54 ` Jeff Layton [this message]
2010-07-19 20:50 ` [PATCH 2/5] nfsd: fix error handling when starting nfsd with rpcbind down Jeff Layton
2010-07-19 20:50 ` [PATCH 3/5] nfsd: fix error handling in __write_ports_addxprt Jeff Layton
2010-07-19 20:50 ` [PATCH 4/5] nfsd: shut down NFSv4 state when nfsd_svc encounters an error Jeff Layton
2010-07-19 20:50 ` [PATCH 5/5] nfsd: just keep single lockd reference for nfsd Jeff Layton
2010-07-20 15:02 ` J. Bruce Fields
2010-07-20 15:43 ` Jeff Layton
2010-07-20 14:55 ` [PATCH 0/5] nfsd: fix error handling in write_ports interfaces (resend) J. Bruce Fields
2010-07-20 15:43 ` Jeff Layton
2010-07-20 15:56 ` J. Bruce Fields
2010-07-20 15:43 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719205450.3a194116@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).