From: "J. Bruce Fields" <bfields@fieldses.org>
To: Staubach_Peter@emc.com
Cc: jlayton@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 5/5] nfsd: just keep single lockd reference for nfsd (try #4)
Date: Thu, 22 Jul 2010 08:26:30 -0400 [thread overview]
Message-ID: <20100722122630.GA13640@fieldses.org> (raw)
In-Reply-To: <BF3BB6D12298F54B89C8DCC1E4073D8001E488B3@CORPUSMX50A.corp.emc.com>
On Thu, Jul 22, 2010 at 07:59:39AM -0400, Staubach_Peter@emc.com wrote:
> +static int nfsd_init_socks(int port)
> +{
> + int error;
> + if (!list_empty(&nfsd_serv->sv_permsocks))
> + return 0;
> +
> + error = svc_create_xprt(nfsd_serv, "udp", PF_INET, port,
> + SVC_SOCK_DEFAULTS);
> + if (error < 0)
> + return error;
> +
> + error = svc_create_xprt(nfsd_serv, "tcp", PF_INET, port,
> + SVC_SOCK_DEFAULTS);
> + if (error < 0)
> + return error;
>
> Doesn't this leave something dangling if svc_create_xprt for "udp"
> succeeds,
> but svc_create_xprt for "tcp" fails?
Yeah, but those sockets are all cleaned up when nfsd_serv is destroyed,
so I think we can live with this.
--b.
next prev parent reply other threads:[~2010-07-22 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 13:21 [PATCH 5/5] nfsd: just keep single lockd reference for nfsd (try #4) Jeff Layton
2010-07-21 20:14 ` J. Bruce Fields
2010-07-21 23:24 ` J. Bruce Fields
2010-07-21 23:26 ` [PATCH 1/7] nfsd4: fix v4 state shutdown error paths J. Bruce Fields
2010-07-21 23:26 ` [PATCH 2/7] nfsd: fix error handling when starting nfsd with rpcbind down J. Bruce Fields
2010-07-21 23:26 ` [PATCH 3/7] nfsd: fix error handling in __write_ports_addxprt J. Bruce Fields
2010-07-21 23:26 ` [PATCH 4/7] nfsd: clean up nfsd_create_serv error handling J. Bruce Fields
2010-07-21 23:26 ` [PATCH 5/7] nfsd: just keep single lockd reference for nfsd J. Bruce Fields
2010-07-21 23:26 ` [PATCH 6/7] nfsd: move more into nfsd_startup() J. Bruce Fields
2010-07-21 23:26 ` [PATCH 7/7] nfsd: minor nfsd_svc() cleanup J. Bruce Fields
2010-07-22 17:40 ` [PATCH 5/5] nfsd: just keep single lockd reference for nfsd (try #4) Jeff Layton
[not found] ` <20100722134026.62091dc2-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2010-07-23 12:55 ` J. Bruce Fields
2010-07-22 11:59 ` Staubach_Peter
2010-07-22 12:26 ` J. Bruce Fields [this message]
2010-07-22 12:36 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722122630.GA13640@fieldses.org \
--to=bfields@fieldses.org \
--cc=Staubach_Peter@emc.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).