Linux NFS development
 help / color / mirror / Atom feed
From: Fabio Olive Leite <fleite@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH] Remove incorrect do_vfs_lock message
Date: Tue, 7 Sep 2010 02:56:01 -0300	[thread overview]
Message-ID: <20100907025601.22a5ea2f@sleipnir.ol> (raw)

The do_vfs_lock function on fs/nfs/file.c is only called if NLM is
not being used, via the -onolock mount option. Therefore it cannot
really be "out of sync with lock manager" when the local locking
function called returns an error, as there will be no corresponding
call to the NLM. For details, simply check the if/else on do_setlk
and do_unlk on fs/nfs/file.c.

Signed-Off-By: Fabio Olive Leite <fleite@redhat.com>

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -723,10 +723,6 @@ static int do_vfs_lock(struct file *file, struct file_lock *fl)
 		default:
 			BUG();
 	}
-	if (res < 0)
-		dprintk(KERN_WARNING "%s: VFS is out of sync with lock manager"
-			" - error %d!\n",
-				__func__, res);
 	return res;
 }
 

Please keep me copied as I don't subscribe to the list.

Regards,
Fábio Olivé
-- 
TcheLinux.org, OeSC-Livre.org, Chapecó, SC
ex sed lex awk yacc, e pluribus unix, amem

             reply	other threads:[~2010-09-07  5:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07  5:56 Fabio Olive Leite [this message]
     [not found] ` <20100907025601.22a5ea2f-rz8jLxre1qydWlpZFn+bTg@public.gmane.org>
2010-09-07 17:25   ` [PATCH] Remove incorrect do_vfs_lock message J. Bruce Fields
2010-09-07 17:38   ` Jeff Layton
     [not found]     ` <20100907133854.1936b695-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-09-07 18:24       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100907025601.22a5ea2f@sleipnir.ol \
    --to=fleite@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox