Re: [PATCH 08/13] RFC: pnfs: filelayout: introduce minimal file layout driver

Trond Myklebust
2010-09-11T00:04:05Z

On Fri, 2010-09-10 at 19:56 -0400, Christoph Hellwig wrote:
> On Fri, Sep 10, 2010 at 03:31:51PM -0400, Trond Myklebust wrote:
> > > + tristate
> > > + depends on NFS_FS && NFS_V4_1
> > > + default m
> >
> > Should be 'default y', otherwise it has an implicit dependency on
> > CONFIG_MODULES.
>
> No, it should not have a default statement at all. The only reason to
> put in a default statement is to keep existing code working when it's
> split into multiple options, which this is not. This is not just my
> opinion, btw - Linus has frequently whacked people for introducing pointless
> defaults in the past.
>
> And even if it was okay sometimes pnfs nowhere is near important enough
> to add it in Kconfig.

So you are saying we should simply equate CONFIG_PNFS_FILE_LAYOUT and
CONFIG_NFS_V4_1 right now? Yep, I'd be fine with that... I'm still
working on the patches to get rid of all these CONFIG options, but
ultimately this is what I'm working towards.

Cheers
Trond