linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 17/22] NFS: Switch in new NFSv3 decoder functions
Date: Fri, 17 Sep 2010 12:29:06 -0400	[thread overview]
Message-ID: <20100917162906.19761.44574.stgit@seurat.1015granger.net> (raw)
In-Reply-To: <20100917162204.19761.58249.stgit@seurat.1015granger.net>

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 fs/nfs/nfs3xdr.c |   64 +++++++++++++++++++++++++-----------------------------
 1 files changed, 30 insertions(+), 34 deletions(-)

diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c
index f77ad7f..0b025b1 100644
--- a/fs/nfs/nfs3xdr.c
+++ b/fs/nfs/nfs3xdr.c
@@ -38,14 +38,10 @@
 #define NFS3_path_sz		(1+(NFS3_MAXPATHLEN>>2))
 #define NFS3_fattr_sz		(21)
 #define NFS3_cookieverf_sz	(NFS3_COOKIEVERFSIZE>>2)
-#define NFS3_wcc_attr_sz		(6)
+#define NFS3_wcc_attr_sz	(6)
 #define NFS3_pre_op_attr_sz	(1+NFS3_wcc_attr_sz)
 #define NFS3_post_op_attr_sz	(1+NFS3_fattr_sz)
-#define NFS3_wcc_data_sz		(NFS3_pre_op_attr_sz+NFS3_post_op_attr_sz)
-#define NFS3_fsstat_sz		
-#define NFS3_fsinfo_sz		
-#define NFS3_pathconf_sz		
-#define NFS3_entry_sz		(NFS3_filename_sz+3)
+#define NFS3_wcc_data_sz	(NFS3_pre_op_attr_sz+NFS3_post_op_attr_sz)
 #define NFS3_diropargs_sz	(NFS3_fh_sz+NFS3_filename_sz)
 
 #define NFS3_getattrargs_sz	(NFS3_fh_sz)
@@ -66,9 +62,9 @@
 #define NFS3_readdirplusargs_sz	(NFS3_fh_sz+NFS3_cookieverf_sz+4)
 #define NFS3_commitargs_sz	(NFS3_fh_sz+3)
 
-#define NFS3_attrstat_sz	(1+NFS3_fattr_sz)
-#define NFS3_wccstat_sz		(1+NFS3_wcc_data_sz)
-#define NFS3_removeres_sz	(NFS3_wccstat_sz)
+#define NFS3_getattrres_sz	(1+NFS3_fattr_sz)
+#define NFS3_setattrres_sz	(1+NFS3_wcc_data_sz)
+#define NFS3_removeres_sz	(NFS3_setattrres_sz)
 #define NFS3_lookupres_sz	(1+NFS3_fh_sz+(2 * NFS3_post_op_attr_sz))
 #define NFS3_accessres_sz	(1+NFS3_post_op_attr_sz+1)
 #define NFS3_readlinkres_sz	(1+NFS3_post_op_attr_sz+1)
@@ -3037,36 +3033,36 @@ out_default:
 [NFS3PROC_##proc] = {							\
 	.p_proc      = NFS3PROC_##proc,					\
 	.p_encode    = (kxdrproc_t) nfs3_xdr_enc_##argtype##3args,	\
-	.p_decode    = (kxdrproc_t) nfs3_xdr_##restype,			\
+	.p_decode    = (kxdrproc_t) nfs3_xdr_dec_##restype##3res,	\
 	.p_arglen    = NFS3_##argtype##args_sz,				\
-	.p_replen    = NFS3_##restype##_sz,				\
+	.p_replen    = NFS3_##restype##res_sz,				\
 	.p_timer     = timer,						\
 	.p_statidx   = NFS3PROC_##proc,					\
 	.p_name      = #proc,						\
 	}
 
 struct rpc_procinfo	nfs3_procedures[] = {
-  PROC(GETATTR,		getattr,	attrstat, 1),
-  PROC(SETATTR,		setattr,	wccstat, 0),
-  PROC(LOOKUP,		lookup,		lookupres, 2),
-  PROC(ACCESS,		access,		accessres, 1),
-  PROC(READLINK,	readlink,	readlinkres, 3),
-  PROC(READ,		read,		readres, 3),
-  PROC(WRITE,		write,		writeres, 4),
-  PROC(CREATE,		create,		createres, 0),
-  PROC(MKDIR,		mkdir,		createres, 0),
-  PROC(SYMLINK,		symlink,	createres, 0),
-  PROC(MKNOD,		mknod,		createres, 0),
-  PROC(REMOVE,		remove,		removeres, 0),
-  PROC(RMDIR,		lookup,		wccstat, 0),
-  PROC(RENAME,		rename,		renameres, 0),
-  PROC(LINK,		link,		linkres, 0),
-  PROC(READDIR,		readdir,	readdirres, 3),
-  PROC(READDIRPLUS,	readdirplus,	readdirres, 3),
-  PROC(FSSTAT,		getattr,	fsstatres, 0),
-  PROC(FSINFO,		getattr,	fsinfores, 0),
-  PROC(PATHCONF,	getattr,	pathconfres, 0),
-  PROC(COMMIT,		commit,		commitres, 5),
+  PROC(GETATTR,		getattr,	getattr,	1),
+  PROC(SETATTR,		setattr,	setattr,	0),
+  PROC(LOOKUP,		lookup,		lookup,		2),
+  PROC(ACCESS,		access,		access,		1),
+  PROC(READLINK,	readlink,	readlink,	3),
+  PROC(READ,		read,		read,		3),
+  PROC(WRITE,		write,		write,		4),
+  PROC(CREATE,		create,		create,		0),
+  PROC(MKDIR,		mkdir,		create,		0),
+  PROC(SYMLINK,		symlink,	create,		0),
+  PROC(MKNOD,		mknod,		create,		0),
+  PROC(REMOVE,		remove,		remove,		0),
+  PROC(RMDIR,		lookup,		setattr,	0),
+  PROC(RENAME,		rename,		rename,		0),
+  PROC(LINK,		link,		link,		0),
+  PROC(READDIR,		readdir,	readdir,	3),
+  PROC(READDIRPLUS,	readdirplus,	readdir,	3),
+  PROC(FSSTAT,		getattr,	fsstat,		0),
+  PROC(FSINFO,		getattr,	fsinfo,		0),
+  PROC(PATHCONF,	getattr,	pathconf,	0),
+  PROC(COMMIT,		commit,		commit,		5),
 };
 
 struct rpc_version		nfs_version3 = {
@@ -3080,7 +3076,7 @@ static struct rpc_procinfo	nfs3_acl_procedures[] = {
 	[ACLPROC3_GETACL] = {
 		.p_proc = ACLPROC3_GETACL,
 		.p_encode = (kxdrproc_t) nfs3_xdr_enc_getacl3args,
-		.p_decode = (kxdrproc_t) nfs3_xdr_getaclres,
+		.p_decode = (kxdrproc_t) nfs3_xdr_dec_getacl3res,
 		.p_arglen = ACL3_getaclargs_sz,
 		.p_replen = ACL3_getaclres_sz,
 		.p_timer = 1,
@@ -3089,7 +3085,7 @@ static struct rpc_procinfo	nfs3_acl_procedures[] = {
 	[ACLPROC3_SETACL] = {
 		.p_proc = ACLPROC3_SETACL,
 		.p_encode = (kxdrproc_t) nfs3_xdr_enc_setacl3args,
-		.p_decode = (kxdrproc_t) nfs3_xdr_setaclres,
+		.p_decode = (kxdrproc_t) nfs3_xdr_dec_setacl3res,
 		.p_arglen = ACL3_setaclargs_sz,
 		.p_replen = ACL3_setaclres_sz,
 		.p_timer = 0,


  parent reply	other threads:[~2010-09-17 16:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17 16:26 [PATCH 00/22] Full NFSv2/v3 XDR overhaul series Chuck Lever
2010-09-17 16:26 ` [PATCH 01/22] NFS: Fix NFSv3 debugging messages in fs/nfs/nfs3proc.c Chuck Lever
2010-09-17 16:26 ` [PATCH 02/22] SUNRPC: Correct an rpcbind debugging message Chuck Lever
2010-09-17 16:26 ` [PATCH 03/22] SUNRPC: Refactor logic to NUL-terminate strings in pages Chuck Lever
2010-09-17 16:26 ` [PATCH 04/22] NFS: Introduce new-style XDR encoding functions for NFSv2 Chuck Lever
2010-09-17 16:27 ` [PATCH 05/22] NFS: Remove old NFSv2 encoder functions Chuck Lever
2010-09-17 16:27 ` [PATCH 06/22] NFS: Move and update xdr_encode_foo() functions that we're keeping Chuck Lever
2010-09-17 16:27 ` [PATCH 07/22] NFS: Use the "nfs_stat" enum for nfs_stat_to_errno()'s argument Chuck Lever
2010-09-17 16:27 ` [PATCH 08/22] NFS: Introduce new-style XDR decoding functions for NFSv2 Chuck Lever
2010-09-17 16:27 ` [PATCH 09/22] NFS: Replace old NFSv2 decoder functions with xdr_stream-based ones Chuck Lever
2010-09-17 16:27 ` [PATCH 10/22] NFS: Move and update xdr_decode_foo() functions that we're keeping Chuck Lever
2010-09-17 16:28 ` [PATCH 11/22] lockd: Introduce new-style XDR functions for NLMv3 Chuck Lever
2010-09-17 16:28 ` [PATCH 12/22] NFS: Introduce new-style XDR encoding functions for NFSv3 Chuck Lever
2010-09-17 16:28 ` [PATCH 13/22] NFS: Replace old NFSv3 encoder functions with xdr_stream-based ones Chuck Lever
2010-09-17 16:28 ` [PATCH 14/22] NFS: Remove unused old NFSv3 encoder functions Chuck Lever
2010-09-17 16:28 ` [PATCH 15/22] NFS: Move and update xdr_encode_foo() functions that we're keeping Chuck Lever
2010-09-17 16:28 ` [PATCH 16/22] NFS: Introduce new-style XDR decoding functions for NFSv2 Chuck Lever
2010-09-17 16:29 ` Chuck Lever [this message]
2010-09-17 16:29 ` [PATCH 18/22] NFS: Remove unused old NFSv3 decoder functions Chuck Lever
2010-09-17 16:29 ` [PATCH 19/22] NFS: Move and update xdr_decode_foo() functions that we're keeping Chuck Lever
2010-09-17 16:29 ` [PATCH 20/22] lockd: Introduce new-style XDR functions for NLMv4 Chuck Lever
2010-09-17 16:29 ` [PATCH 21/22] lockd: Move nlmdbg_cookie2a() to svclock.c Chuck Lever
2010-09-17 16:29 ` [PATCH 22/22] NFS: Fix hdrlen calculation in NFSv4's decode_read() Chuck Lever
  -- strict thread matches above, loose matches on Subject: below --
2010-07-02 17:18 [PATCH 00/22] NFS v2 and v3 XDR overhaul Chuck Lever
     [not found] ` <20100702165935.8761.88528.stgit-ewv44WTpT0t9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2010-07-02 17:21   ` [PATCH 17/22] NFS: Switch in new NFSv3 decoder functions Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100917162906.19761.44574.stgit@seurat.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).