From: Chuck Lever <chuck.lever@oracle.com>
To: steved@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 3/7] mountd: Unregister mountd if my_svc_run() returns
Date: Mon, 20 Sep 2010 12:32:54 -0400 [thread overview]
Message-ID: <20100920163254.3170.30786.stgit@ellison.1015granger.net> (raw)
In-Reply-To: <20100920162616.3170.24625.stgit@ellison.1015granger.net>
Fix a long standing bug: when my_svc_run() returns, mountd should
unregister itself with the local rpcbind so that it can subsequently
start cleanly.
Log a more helpful error message in this case.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
utils/mountd/mountd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
index a4fdcc8..9c7caf9 100644
--- a/utils/mountd/mountd.c
+++ b/utils/mountd/mountd.c
@@ -888,7 +888,8 @@ main(int argc, char **argv)
my_svc_run();
- xlog(L_ERROR, "Ack! Gack! svc_run returned!\n");
+ xlog(L_ERROR, "RPC service loop terminated unexpectedly. Exiting...\n");
+ unregister_services();
exit(1);
}
next prev parent reply other threads:[~2010-09-20 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 16:32 [PATCH 0/7] The final patches for mountd IPv6 support Chuck Lever
2010-09-20 16:32 ` [PATCH 1/7] mountd: Make NFS version checks more strict Chuck Lever
2010-09-20 16:32 ` [PATCH 2/7] mountd: Support TI-RPC mountd listener Chuck Lever
2010-09-20 16:32 ` Chuck Lever [this message]
2010-09-20 16:33 ` [PATCH 4/7] mountd: Fix up version and usage messages Chuck Lever
2010-09-20 16:33 ` [PATCH 5/7] mountd: Use MNT status values instead of NFSERR Chuck Lever
2010-09-20 16:33 ` [PATCH 6/7] mountd: Update mountd/exportfs man pages to reflect IPv6 changes Chuck Lever
2010-09-20 16:33 ` [PATCH 7/7] nfsd: Enable IPv6 support in rpc.nfsd again Chuck Lever
[not found] ` <20100920162616.3170.24625.stgit-ewv44WTpT0t9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2010-09-28 12:08 ` [PATCH 0/7] The final patches for mountd IPv6 support Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920163254.3170.30786.stgit@ellison.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).