Linux NFS development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH nfsd-next] nfsd: Export get_task_comm for nfsd
Date: Thu, 23 Sep 2010 10:05:50 -0400	[thread overview]
Message-ID: <20100923140550.GA10137@infradead.org> (raw)
In-Reply-To: <4C9B176E.4090808@parallels.com>

On Thu, Sep 23, 2010 at 01:01:34PM +0400, Pavel Emelyanov wrote:
> The git://linux-nfs.org/~bfields/linux.git nfsd-next branch doesn't
> compile when nfsd is a module with the following error:
> 
>    ERROR: "get_task_comm" [fs/nfsd/nfsd.ko] undefined!
> 
> The get_task_comm is used in nfsctl_transaction_read's printk.

Why doesn't it simply use current->comm as countless other users?
Assuming it doesn't actually want to print comm for a non-current users
which would rather surprise me.

  reply	other threads:[~2010-09-23 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23  9:01 [PATCH nfsd-next] nfsd: Export get_task_comm for nfsd Pavel Emelyanov
2010-09-23 14:05 ` Christoph Hellwig [this message]
2010-09-23 14:26   ` Pavel Emelyanov
2010-09-23 14:39     ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100923140550.GA10137@infradead.org \
    --to=hch@infradead.org \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox