From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([174.143.236.118]:43350 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754270Ab0IWOsS (ORCPT ); Thu, 23 Sep 2010 10:48:18 -0400 Date: Thu, 23 Sep 2010 10:46:47 -0400 From: "J. Bruce Fields" To: Neil Brown Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/7] sunrpc: fix race in new cache_wait code. Message-ID: <20100923144647.GD1054@fieldses.org> References: <20100922025009.31745.98237.stgit@localhost.localdomain> <20100922025506.31745.67177.stgit@localhost.localdomain> <20100922175027.GF15560@fieldses.org> <20100923130002.5f2da3e9@notabene> <20100923032540.GA13554@fieldses.org> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100923032540.GA13554@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Wed, Sep 22, 2010 at 11:25:40PM -0400, J. Bruce Fields wrote: > On Thu, Sep 23, 2010 at 01:00:02PM +1000, Neil Brown wrote: > > How about this. > > It gets rid of the return values (which were confusing anyway) and adds > > explicit checks on CAHCE_PENDING where needed. > > ?? > > Thanks, I'll take a look in the morning when my head's (hopefully) > clearer. Looks reasonable to me on a quick skim. > > Also, I noticed there is a race with the call to cache_limit_defers. The > > 'dreq' could be freed before that is called. > > > > It looks like I need to resubmit a lot of this - do you want to just discard > > it all from your -next and I'll make something new? > > I'm trying very hard not to rewind -next; so I'd prefer incremental > patches for anything already there, replacements for the rest. But I'll wait for a new series. Thanks! --b.