From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Bryan Schumaker <bjschuma@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: rename idmapper components
Date: Tue, 26 Oct 2010 13:20:17 -0400 [thread overview]
Message-ID: <20101026172016.GA526@fieldses.org> (raw)
In-Reply-To: <1288100354.9435.5.camel@heimdal.trondhjem.org>
On Tue, Oct 26, 2010 at 09:39:14AM -0400, Trond Myklebust wrote:
> On Tue, 2010-10-26 at 09:17 -0400, Bryan Schumaker wrote:
> > This patch renames the idmapper upcall program from nfs.upcall to nfs.idmap.
> > It also changes the key type from id_resolver to nfs_idmap.
...
> We should _not_ be doing this kind of user space api change after the
> code has been merged by Linus.
>
> I don't mind a patch to the documentation that changes 'nfs.upcall' to
> match the name given in nfs-utils, but it is too late to change the name
> 'id_resolver': that should have been done before the merge window.
There's precedent for fixing new interfaces before the final release, so
it seems unlikely to be a huge problem before -rc1.
Though agreed that there should still be a higher standard for changes
made after the moment the interface is merged--and a slightly
inconsistent name may not meet the standard....
--b.
next prev parent reply other threads:[~2010-10-26 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 13:17 [PATCH] NFS: rename idmapper components Bryan Schumaker
2010-10-26 13:39 ` Trond Myklebust
2010-10-26 17:20 ` J. Bruce Fields [this message]
2010-10-26 17:27 ` Trond Myklebust
[not found] ` <1288114038.12370.8.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2010-10-26 17:30 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026172016.GA526@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).