From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from magus.merit.edu ([198.108.1.13]:49804 "EHLO magus.merit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754932Ab0J1P7R (ORCPT ); Thu, 28 Oct 2010 11:59:17 -0400 Date: Thu, 28 Oct 2010 11:59:15 -0400 From: Jim Rees To: Steve Dickson Cc: Christoph Hellwig , linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfs-utils: Check for strlcat/cpy and compile our private version only if it's needed. Message-ID: <20101028155915.GA1685@merit.edu> References: <20101020213554.GA27541@merit.edu> <20101021021437.GA5241@infradead.org> <20101021120110.GA29219@merit.edu> <4CC97D4C.1030007@RedHat.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <4CC97D4C.1030007@RedHat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Steve Dickson wrote: On 10/21/2010 08:01 AM, Jim Rees wrote: > Christoph Hellwig wrote: > > Not that I'd complain, but what Linux libc provides strlcat/cpy? > > None that I know of. The patch seems like a good idea to me, but it does > add a couple of ugly ifdefs to the include file. > > There are already quite a few much sillier checks in configure.ac, like > memset, socket, and mkdir. > > But I won't object if you want to drop this patch. I think if/when there is a need for these checks we can add them in then... Why add to the ugliness if we don't need to? Fine with me. I was feeling guilty because I think I'm the one who originally put the strlcat/cpy calls in, way back when idmapd did run on non-linux platforms.