From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "William A. (Andy) Adamson" <androsadamson@gmail.com>,
benny@panasas.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] NFS add minorversion to nfs_find_client search
Date: Thu, 18 Nov 2010 12:39:49 -0500 [thread overview]
Message-ID: <20101118173949.GA28975@fieldses.org> (raw)
In-Reply-To: <1290091562.3187.16.camel@heimdal.trondhjem.org>
On Thu, Nov 18, 2010 at 09:46:02AM -0500, Trond Myklebust wrote:
> I can see why the NFS server would care to let the client quickly
> whether or not the RPC request is denied, but why do we care on the
> backchannel case? If a server is sending us callbacks, and we don't
> recognise that server, why should we waste computing and networking
> cycles by replying at all?
Agreed. I have a hard time seeing a real benefit to returning an error
here.
Also, note the only reason to use pg_authenticate is if you want to
return an rpc-level error.
Not that it's a problem to do the work here in pg_authenticate if you
want to, but if it's easier to just allow the request through and let
the nfs layer decide what to do with it, that shouldn't be a problem
either.
--b.
next prev parent reply other threads:[~2010-11-18 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 3:36 [PATCH 0/3] NFSv4 callback pg_authenticate fix andros
2010-11-17 3:36 ` [PATCH 1/3] NFS add minorversion to nfs_find_client search andros
2010-11-17 3:36 ` [PATCH 2/3] SQUASHME: pnfs-submit: fix highest backchannel slot used andros
2010-11-17 3:36 ` [PATCH 3/3] NFS return an rpc auth error on back channel andros
2010-11-17 23:26 ` Trond Myklebust
2010-11-18 14:42 ` William A. (Andy) Adamson
2010-11-18 15:05 ` Trond Myklebust
2010-11-18 15:08 ` William A. (Andy) Adamson
2010-11-17 23:10 ` [PATCH 1/3] NFS add minorversion to nfs_find_client search Trond Myklebust
2010-11-18 14:11 ` William A. (Andy) Adamson
2010-11-18 14:46 ` Trond Myklebust
2010-11-18 17:39 ` J. Bruce Fields [this message]
2010-11-17 22:49 ` [PATCH 0/3] NFSv4 callback pg_authenticate fix J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118173949.GA28975@fieldses.org \
--to=bfields@fieldses.org \
--cc=androsadamson@gmail.com \
--cc=benny@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).