From: Jim Rees <rees@umich.edu>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] nfsd: fix offset printk's in nfsd3 read/write
Date: Mon, 6 Dec 2010 19:31:04 -0500 [thread overview]
Message-ID: <20101207003104.GA4317@merit.edu> (raw)
In-Reply-To: <1291680566-13980-4-git-send-email-bfields@redhat.com>
J. Bruce Fields wrote:
Thanks to dysbr01@ca.com for noticing that the debugging printk in
the v3 write procedure can print >2GB offsets as negative numbers:
https://bugzilla.kernel.org/show_bug.cgi?id=23342
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/nfsd/nfs3proc.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 5b7e302..2247fc9 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -151,10 +151,10 @@ nfsd3_proc_read(struct svc_rqst *rqstp, struct nfsd3_readargs *argp,
__be32 nfserr;
u32 max_blocksize = svc_max_payload(rqstp);
- dprintk("nfsd: READ(3) %s %lu bytes at %lu\n",
+ dprintk("nfsd: READ(3) %s %lu bytes at %Lu\n",
Isn't "llu" preferred over "Lu" these days?
next prev parent reply other threads:[~2010-12-07 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 0:09 minor fix for 2.6.38 J. Bruce Fields
2010-12-07 0:09 ` [PATCH 1/3] nfsd4: replace unintuitive match_clientid_establishment J. Bruce Fields
2010-12-09 13:32 ` Benny Halevy
2010-12-07 0:09 ` [PATCH 2/3] nfsd4: fix mixed 4.0/4.1 handling, 4.1 reboot J. Bruce Fields
2010-12-09 13:37 ` Benny Halevy
2010-12-11 0:14 ` J. Bruce Fields
2010-12-07 0:09 ` [PATCH 3/3] nfsd: fix offset printk's in nfsd3 read/write J. Bruce Fields
2010-12-07 0:31 ` Jim Rees [this message]
2010-12-07 22:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207003104.GA4317@merit.edu \
--to=rees@umich.edu \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).