From: "J. Bruce Fields" <bfields@fieldses.org>
To: bookjovi@gmail.com
Cc: neilb@suse.de, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: add missed CONFIG_NFSD_DEPRECATED
Date: Mon, 13 Dec 2010 19:13:34 -0500 [thread overview]
Message-ID: <20101214001334.GH9394@fieldses.org> (raw)
In-Reply-To: <1292044877-4701-1-git-send-email-bookjovi@gmail.com>
On Sat, Dec 11, 2010 at 12:21:17AM -0500, bookjovi@gmail.com wrote:
> these pieces of code only make sense when CONFIG_NFSD_DEPRECATED enabled
>
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
OK, thanks; applied for 2.6.38.--b.
>
> fs/nfsd/nfsctl.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 4514ebb..6840ec3 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -127,6 +127,7 @@ static ssize_t nfsctl_transaction_write(struct file *file, const char __user *bu
>
> static ssize_t nfsctl_transaction_read(struct file *file, char __user *buf, size_t size, loff_t *pos)
> {
> +#ifdef CONFIG_NFSD_DEPRECATED
> static int warned;
> if (file->f_dentry->d_name.name[0] == '.' && !warned) {
> printk(KERN_INFO
> @@ -135,6 +136,7 @@ static ssize_t nfsctl_transaction_read(struct file *file, char __user *buf, size
> current->comm, file->f_dentry->d_name.name);
> warned = 1;
> }
> +#endif
> if (! file->private_data) {
> /* An attempt to read a transaction file without writing
> * causes a 0-byte write so that the file can return
prev parent reply other threads:[~2010-12-14 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 5:21 [PATCH] nfs: add missed CONFIG_NFSD_DEPRECATED bookjovi
2010-12-14 0:13 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214001334.GH9394@fieldses.org \
--to=bfields@fieldses.org \
--cc=bookjovi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).