From: "J. Bruce Fields" <bfields@fieldses.org>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: neilb@suse.de, Trond.Myklebust@netapp.com, steved@redhat.com,
tj@kernel.org, David Miller <davem@davemloft.net>,
linux-nfs@vger.kernel.org,
Network-Maillist <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/3] net: sunrpc: kill unused macros
Date: Wed, 15 Dec 2010 10:52:07 -0500 [thread overview]
Message-ID: <20101215155206.GC32559@fieldses.org> (raw)
In-Reply-To: <4D086478.7090106@cn.fujitsu.com>
On Wed, Dec 15, 2010 at 02:47:20PM +0800, Shan Wei wrote:
> These macros never be used for several years.
Applying for 2.6.38.--b.
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> ---
> net/sunrpc/auth_gss/svcauth_gss.c | 2 --
> net/sunrpc/svcauth.c | 1 -
> net/sunrpc/svcauth_unix.c | 2 --
> 3 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index dec2a6f..bcdae78 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -67,7 +67,6 @@ static int netobj_equal(struct xdr_netobj *a, struct xdr_netobj *b)
>
> #define RSI_HASHBITS 6
> #define RSI_HASHMAX (1<<RSI_HASHBITS)
> -#define RSI_HASHMASK (RSI_HASHMAX-1)
>
> struct rsi {
> struct cache_head h;
> @@ -319,7 +318,6 @@ static struct rsi *rsi_update(struct rsi *new, struct rsi *old)
>
> #define RSC_HASHBITS 10
> #define RSC_HASHMAX (1<<RSC_HASHBITS)
> -#define RSC_HASHMASK (RSC_HASHMAX-1)
>
> #define GSS_SEQ_WIN 128
>
> diff --git a/net/sunrpc/svcauth.c b/net/sunrpc/svcauth.c
> index 4e9393c..7963569 100644
> --- a/net/sunrpc/svcauth.c
> +++ b/net/sunrpc/svcauth.c
> @@ -118,7 +118,6 @@ EXPORT_SYMBOL_GPL(svc_auth_unregister);
>
> #define DN_HASHBITS 6
> #define DN_HASHMAX (1<<DN_HASHBITS)
> -#define DN_HASHMASK (DN_HASHMAX-1)
>
> static struct hlist_head auth_domain_table[DN_HASHMAX];
> static spinlock_t auth_domain_lock =
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index 560677d..a04ac91 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -85,7 +85,6 @@ static void svcauth_unix_domain_release(struct auth_domain *dom)
> */
> #define IP_HASHBITS 8
> #define IP_HASHMAX (1<<IP_HASHBITS)
> -#define IP_HASHMASK (IP_HASHMAX-1)
>
> struct ip_map {
> struct cache_head h;
> @@ -497,7 +496,6 @@ svcauth_unix_info_release(struct svc_xprt *xpt)
> */
> #define GID_HASHBITS 8
> #define GID_HASHMAX (1<<GID_HASHBITS)
> -#define GID_HASHMASK (GID_HASHMAX - 1)
>
> struct unix_gid {
> struct cache_head h;
> --
> 1.6.3.3
prev parent reply other threads:[~2010-12-15 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 6:47 [PATCH 2/3] net: sunrpc: kill unused macros Shan Wei
2010-12-15 15:52 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215155206.GC32559@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=steved@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).