linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Nick Piggin <npiggin@kernel.dk>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Nick Piggin <npiggin@gmail.com>,
	linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] fs/dcache: use standard list macro for d_find_alias
Date: Fri, 17 Dec 2010 12:53:55 -0500	[thread overview]
Message-ID: <20101217175355.GA11515@fieldses.org> (raw)
In-Reply-To: <20101214220102.GM24828@fieldses.org>

From: J. Bruce Fields <bfields@redhat.com>

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/dcache.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

While I'm here....  Am I overlooking some reason we're not doing this
the easy way?

diff --git a/fs/dcache.c b/fs/dcache.c
index 23702a9..5ed93cd 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -358,16 +358,9 @@ EXPORT_SYMBOL(dget_locked);
 
 static struct dentry * __d_find_alias(struct inode *inode, int want_discon)
 {
-	struct list_head *head, *next, *tmp;
 	struct dentry *alias, *discon_alias=NULL;
 
-	head = &inode->i_dentry;
-	next = inode->i_dentry.next;
-	while (next != head) {
-		tmp = next;
-		next = tmp->next;
-		prefetch(next);
-		alias = list_entry(tmp, struct dentry, d_alias);
+	list_for_each_entry(alias, &inode->i_dentry, d_alias) {
  		if (S_ISDIR(inode->i_mode) || !d_unhashed(alias)) {
 			if (IS_ROOT(alias) &&
 			    (alias->d_flags & DCACHE_DISCONNECTED))
-- 
1.7.1


  reply	other threads:[~2010-12-17 17:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 18:43 lifetime of DCACHE_DISCONECTED dentries J. Bruce Fields
2010-11-13 11:53 ` Nick Piggin
2010-11-15 17:48   ` J. Bruce Fields
2010-11-16  6:45     ` Nick Piggin
2010-11-29  3:56       ` Nick Piggin
2010-11-29 19:32         ` J. Bruce Fields
2010-11-30  1:00           ` Nick Piggin
2010-11-30 18:39             ` J. Bruce Fields
2010-12-03 22:33             ` [PATCH] nfsd4: allow __d_obtain_alias() to return unhashed dentries J. Bruce Fields
2010-12-13  5:19               ` Nick Piggin
2010-12-14 22:01                 ` J. Bruce Fields
2010-12-17 17:53                   ` J. Bruce Fields [this message]
2010-12-17 18:00                   ` [PATCH 2/2] fs/dcache: " J. Bruce Fields
2010-12-18  2:01                     ` Nick Piggin
2010-12-18 16:16                       ` J. Bruce Fields
2010-12-19 14:53                         ` Nick Piggin
2010-12-27 23:46                           ` [PATCH] " J. Bruce Fields
2011-01-18 20:45                             ` J. Bruce Fields
2011-01-18 22:02                               ` Nick Piggin
2011-01-18 22:08                                 ` J. Bruce Fields
2011-03-08 18:13                                   ` J. Bruce Fields
2011-03-10 10:58                                     ` Al Viro
2011-03-11  4:07                                       ` NeilBrown
2012-02-14 17:03                                         ` J. Bruce Fields
2012-02-15 16:56                                           ` J. Bruce Fields
2012-02-16  3:06                                             ` NeilBrown
2012-02-16 11:51                                               ` J. Bruce Fields
2012-02-16 16:08                                                 ` J. Bruce Fields
2012-02-16 22:30                                               ` J. Bruce Fields
2012-02-17 16:34                                                 ` Peng Tao
2012-03-13 20:55                                                   ` J. Bruce Fields
2012-03-13 20:58                                                     ` [PATCH 1/2] vfs: stop d_splice_alias creating directory aliases J. Bruce Fields
2012-03-13 20:58                                                     ` [PATCH 2/2] vfs: remove unused __d_splice_alias argument J. Bruce Fields
2012-02-20  2:55                                                 ` [PATCH] fs/dcache: allow __d_obtain_alias() to return unhashed dentries NeilBrown
2012-02-29 23:10                                                   ` J. Bruce Fields
2012-06-28 13:59                                         ` J. Bruce Fields
2012-06-29 20:10                                           ` J. Bruce Fields
2012-06-29 20:29                                             ` J. Bruce Fields
2012-07-01 23:15                                               ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101217175355.GA11515@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=npiggin@kernel.dk \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).