linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: andros@netapp.com
Cc: trond.myklebust@netapp.com, bfields@redhat.com,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH_V5 09/11] NFS RPC_AUTH_GSS unsupported on v4.1 back channel
Date: Wed, 22 Dec 2010 17:27:38 -0500	[thread overview]
Message-ID: <20101222222738.GF13243@fieldses.org> (raw)
In-Reply-To: <1292879088-7821-10-git-send-email-andros@netapp.com>

On Mon, Dec 20, 2010 at 04:04:46PM -0500, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  fs/nfs/callback.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 541be39..4a9c517 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -368,6 +368,9 @@ static int check_gss_callback_principal(struct nfs_client *clp,
>  	struct rpc_clnt *r = clp->cl_rpcclient;
>  	char *p = svc_gss_principal(rqstp);
>  
> +	/* No RPC_AUTH_GSS on NFSv4.1 back channel yet */
> +	if (clp->cl_minorversion != 0)
> +		return SVC_DENIED;

May as well just drop in this case, actually, right?  You didn't ask for
gss in the create_session, so this would be an outright server bug.

--b.

>  	/*
>  	 * It might just be a normal user principal, in which case
>  	 * userspace won't bother to tell us the name at all.
> -- 
> 1.6.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-12-22 22:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 21:04 [PATCH_V5 0/11] NFSv4 callback find client fix Version 5 andros
2010-12-20 21:04 ` [PATCH_V5 01/11] SUNRPC move svc_drop to caller of svc_process_common andros
2010-12-20 21:04   ` [PATCH_V5 02/11] SUNRPC fix bc_send print andros
2010-12-20 21:04     ` [PATCH_V5 03/11] SUNRPC new transport for the NFSv4.1 shared back channel andros
2010-12-20 21:04       ` [PATCH_V5 04/11] NFS use svc_create_xprt for NFSv4.1 callback service andros
2010-12-20 21:04         ` [PATCH_V5 05/11] NFS do not clear minor version at nfs_client free andros
2010-12-20 21:04           ` [PATCH_V5 06/11] NFS implement v4.0 callback_ident andros
2010-12-20 21:04             ` [PATCH_V5 07/11] NFS associate sessionid with callback connection andros
2010-12-20 21:04               ` [PATCH_V5 08/11] NFS reference nfs_client across cb_compound processing andros
2010-12-20 21:04                 ` [PATCH_V5 09/11] NFS RPC_AUTH_GSS unsupported on v4.1 back channel andros
2010-12-20 21:04                   ` [PATCH_V5 10/11] NFS add session back channel draining andros
2010-12-20 21:04                     ` [PATCH_V5 11/11] NFS rename client back channel transport field andros
2010-12-22 22:27                   ` J. Bruce Fields [this message]
2010-12-22 22:26                 ` [PATCH_V5 08/11] NFS reference nfs_client across cb_compound processing J. Bruce Fields
2010-12-22 22:24       ` [PATCH_V5 03/11] SUNRPC new transport for the NFSv4.1 shared back channel J. Bruce Fields
2010-12-24 17:43         ` J. Bruce Fields
2010-12-21 18:23   ` [PATCH_V5 01/11] SUNRPC move svc_drop to caller of svc_process_common J. Bruce Fields
2010-12-22 22:00     ` Andy Adamson
2010-12-22 22:18       ` J. Bruce Fields
2010-12-24  3:43     ` Labiaga, Ricardo
2010-12-24 17:01       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101222222738.GF13243@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=andros@netapp.com \
    --cc=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).