From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:37839 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027Ab1ADXFa (ORCPT ); Tue, 4 Jan 2011 18:05:30 -0500 Date: Wed, 5 Jan 2011 10:05:22 +1100 From: NeilBrown To: "J. Bruce Fields" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH] svcrpc: modifying positive sunrpc cache entries is racy Message-ID: <20110105100522.45d58ae0@notabene.brown> In-Reply-To: <20110104214639.GG7908@fieldses.org> References: <20101229204752.GC12218@fieldses.org> <20110103222605.GA24811@fieldses.org> <20110104030805.GA3194@fieldses.org> <20110104155107.0ff2c199@notabene.brown> <20110104214639.GG7908@fieldses.org> Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, 4 Jan 2011 16:46:39 -0500 "J. Bruce Fields" wrote: > On Tue, Jan 04, 2011 at 03:51:07PM +1100, NeilBrown wrote: > > And this all made me realise that there is more code that can be placed under > > CONFIG_NFSD_DEPRECTATED. > > > > > > SUNRPC: Remove more code when NFSD_DEPRECATED is not configured > > > > Signed-off-by: NeilBrown > > I did need one change to get a succesful !CONFIG_NFSD_DEPRECATED > compile. yep.... I had done a test compile, but I managed to get the sense of CONFIG_NFSD_DEPRECATED inverted :-( NeilBrown > > --b. > > diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c > index 46e1cbc..30916b0 100644 > --- a/net/sunrpc/svcauth_unix.c > +++ b/net/sunrpc/svcauth_unix.c > @@ -422,6 +422,7 @@ struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr) > return rv; > } > EXPORT_SYMBOL_GPL(auth_unix_lookup); > +#endif /* CONFIG_NFSD_DEPRECATED */ > > void svcauth_unix_purge(void) > { > @@ -435,7 +436,6 @@ void svcauth_unix_purge(void) > } > } > EXPORT_SYMBOL_GPL(svcauth_unix_purge); > -#endif /* CONFIG_NFSD_DEPRECATED */ > > static inline struct ip_map * > ip_map_cached_get(struct svc_xprt *xprt)