From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: sdrb <sdrb-4Uo9UdwAbX8@public.gmane.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Steve Dickson <steved@redhat.com>
Subject: Re: Issue in nfs-utils 1.2.3
Date: Thu, 13 Jan 2011 10:52:20 -0500 [thread overview]
Message-ID: <20110113155220.GE20946@fieldses.org> (raw)
In-Reply-To: <2746C301-E627-4F22-8422-6A4856CF4EC0@oracle.com>
On Thu, Jan 13, 2011 at 10:47:42AM -0500, Chuck Lever wrote:
>
> On Jan 12, 2011, at 11:04 AM, J. Bruce Fields wrote:
>
> > On Wed, Jan 12, 2011 at 02:51:20PM +0100, sdrb wrote:
> >> I've investigated a little the sources and I noticed that probably
> >> there should be some pointer NULL-ed in mountlist_list() procedure
> >> like in patch I've attached.
> >>
> >> Anyone can confirm that such a fix is ok?
> >
> > Thanks for the report.
> >
> > I haven't tried to verify that it could cause the backtrace you saw, but
> > clearly mlist is used after that mountlist_freeall(mlist), so your patch
> > is necessary.
> >
> > Looks like this was introduced with a8348c2c4 "mountd: Add
> > mountlist_freeall()".
>
> Is your theory that the introduction of a function call ( mountlist_freeall() ) hides the side-effects of that while loop, leaving the mlist variable in the mountlist_list() scope pointing at freed memory?
Yup.--b.
>
> > --b.
> >
> >> diff -rNup nfs-utils-1.2.3_orig/utils/mountd/rmtab.c nfs-utils-1.2.3/utils/mountd/rmtab.c
> >> --- nfs-utils-1.2.3/utils/mountd/rmtab.c 2010-09-28 14:24:16.000000000 +0200
> >> +++ nfs-utils-1.2.3/utils/mountd/rmtab.c 2011-01-12 14:44:22.320000000 +0100
> >> @@ -205,6 +205,7 @@ mountlist_list(void)
> >> }
> >> if (stb.st_mtime != last_mtime) {
> >> mountlist_freeall(mlist);
> >> + mlist=NULL;
>
> Nit: Please use white space conventions which match the rest of the file (single blanks around "=").
>
> >> last_mtime = stb.st_mtime;
> >>
> >> setrmtabent("r");
> >
>
> --
> Chuck Lever
> chuck[dot]lever[at]oracle[dot]com
>
>
>
>
prev parent reply other threads:[~2011-01-13 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 11:31 Issue in nfs-utils 1.2.3 sdrb
2011-01-12 13:51 ` sdrb
2011-01-12 16:04 ` J. Bruce Fields
2011-01-13 15:47 ` Chuck Lever
2011-01-13 15:52 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113155220.GE20946@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=sdrb-4Uo9UdwAbX8@public.gmane.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).